Combine TS fixes from PR #35 and apply Python fixes from PR #37#38
Closed
Combine TS fixes from PR #35 and apply Python fixes from PR #37#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
x402while commercial requests include the legacy field where required.Description
typescript-sdk/src/index.tsincludingReceiptProtocolMetadata, makingbuildCommonsRequestomitx402, making commercial payloads includex402, and adding canonicalverbhandling.typescript-sdk/scripts/unit-tests.mjsto assert the current Commons payload shape.build_commons_requestto omitx402andbuild_commercial_requestto includex402inpython-sdk/commandlayer/client.py, madeverify_receiptreturnok=Truefor the valid fixture (removedreceipt_id_matchesdependency) and addedreceipt_id_presentto checks, and enhancedextract_receipt_verbto prefer top-levelverb, fall back tox402.verb, and finally fall back tosummarizefor legacy success-with-summary fixtures inpython-sdk/commandlayer/verify.py.types.py,__init__.py) and updated tests to reflect the new contract semantics (python-sdk/tests/*).Testing
cd typescript-sdk && npm run typecheck && npm run build && npm run test:unitand all TypeScript checks and unit/template tests passed.cd python-sdk && python -m ruff check . && python -m mypy commandlayer && python -m pytest tests/ -vandruff,mypy, andpytestall passed (26 tests).node scripts/parity-check.mjsand the parity report passed with TypeScript and Python verification semantics aligned.Codex Task