Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
typescript-sdk/src/index.ts, returning Commons requests without the legacyx402envelope while preservingx402for commercial requests, addReceiptProtocolMetadata, fixgetReceiptVerbto handle legacy success-summary fallback, wirereceipt_id_presentand signer id correctly, and update unit expectations intypescript-sdk/scripts/unit-tests.mjs.typescript-sdk/scripts/template-tests.mjssoruntime/testsis optional andtypescript-sdk/testsis required, and run each suite with explicitnode --test <files...>invocation.python-sdk/commandlayer/client.py,python-sdk/commandlayer/verify.py, andpython-sdk/commandlayer/types.pyto mirror the TypeScript contract (Commons requests omitx402, commercial requests includex402, normalize legacy responses, addverb/receipt_id_presenttyping, and extendextract_receipt_verbto fallback to legacy success-summary fixtures).python-sdk/tests/test_public_api.pyandpython-sdk/tests/test_client.pyand TypeScript unit tests intypescript-sdk/scripts/unit-tests.mjsto reflect the current Commons shape and the template-runner behavior.Testing
cd typescript-sdk && npm test, which completed successfully (unit tests, template tests and CLI smoke tests all passed).cd python-sdk && python -m ruff check . && python -m mypy commandlayer && python -m pytest tests -q, which completed successfully (lint, type-check, and pytest all passed).node scripts/parity-check.mjs, which passed and shows TypeScript and Python agree on shared verification semantics.Codex Task