Skip to content

Reapply PR #38 TypeScript/Python parity fixes and add PR #39 template-suite discovery#40

Merged
GsCommand merged 1 commit intomainfrom
codex/create-final-pr-from-pr-#38
Apr 24, 2026
Merged

Reapply PR #38 TypeScript/Python parity fixes and add PR #39 template-suite discovery#40
GsCommand merged 1 commit intomainfrom
codex/create-final-pr-from-pr-#38

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

Description

  • TypeScript: align request envelope and verification types in typescript-sdk/src/index.ts, returning Commons requests without the legacy x402 envelope while preserving x402 for commercial requests, add ReceiptProtocolMetadata, fix getReceiptVerb to handle legacy success-summary fallback, wire receipt_id_present and signer id correctly, and update unit expectations in typescript-sdk/scripts/unit-tests.mjs.
  • Template runner: replace the glob-runner with file discovery in typescript-sdk/scripts/template-tests.mjs so runtime/tests is optional and typescript-sdk/tests is required, and run each suite with explicit node --test <files...> invocation.
  • Python: reapply PR#38 fixes in python-sdk/commandlayer/client.py, python-sdk/commandlayer/verify.py, and python-sdk/commandlayer/types.py to mirror the TypeScript contract (Commons requests omit x402, commercial requests include x402, normalize legacy responses, add verb/receipt_id_present typing, and extend extract_receipt_verb to fallback to legacy success-summary fixtures).
  • Tests and test expectations updated: adjusted Python unit tests in python-sdk/tests/test_public_api.py and python-sdk/tests/test_client.py and TypeScript unit tests in typescript-sdk/scripts/unit-tests.mjs to reflect the current Commons shape and the template-runner behavior.

Testing

  • Ran TypeScript full test suite with cd typescript-sdk && npm test, which completed successfully (unit tests, template tests and CLI smoke tests all passed).
  • Ran Python tooling and tests with cd python-sdk && python -m ruff check . && python -m mypy commandlayer && python -m pytest tests -q, which completed successfully (lint, type-check, and pytest all passed).
  • Ran cross-SDK parity with node scripts/parity-check.mjs, which passed and shows TypeScript and Python agree on shared verification semantics.
  • All automated checks executed locally completed successfully.

Codex Task

@GsCommand GsCommand merged commit 06a8b1a into main Apr 24, 2026
10 checks passed
@GsCommand GsCommand deleted the codex/create-final-pr-from-pr-#38 branch April 24, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant