Node 20 template-tests discovery + preserve PR#33 receipt/parity fixes#35
Closed
Node 20 template-tests discovery + preserve PR#33 receipt/parity fixes#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
node --testdiscovery works on Node 20 by avoiding glob patterns while keeping the TypeScript SDK fixes and parity behavior introduced previously.src/index.tstyping and runtime fixes from the prior PR so the SDK compiles and behaves as expected.Description
typescript-sdk/scripts/template-tests.mjswith explicit discovery usingexistsSync/readdirSync/pathand pass explicit test file paths tonode --testto be Node 20-safe.typescript-sdk/src/index.tschanges: alignCommandResponse/LegacyBlendedReceiptgenerics, addReceiptProtocolMetadatatype, wiresigner_idinto verify result values, and centralize receipt-verb extraction viagetReceiptVerb.okpath (setreceipt_id_matches = true) and remove thereceipt_id_presentcheck from the TypeScriptVerifyChecks.receipt_id_matches = Trueinpython-sdk/commandlayer/verify.py, and update the TS unit fixture to include a canonicalverbsoextractReceiptVerbassertions remain valid.Testing
cd typescript-sdk && npm run typecheck && npm run build && npm run test:unitand the TypeScript typecheck, build, unit tests, and template tests all passed.node scripts/parity-check.mjsand the parity check between TypeScript and Python passed.Codex Task