DRYD-1925: Accessibility > Contrast/Design of Buttons (Criteria 1.4.3)#352
Open
spirosdi wants to merge 5 commits into
Open
DRYD-1925: Accessibility > Contrast/Design of Buttons (Criteria 1.4.3)#352spirosdi wants to merge 5 commits into
spirosdi wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It resolves the very low contrast issue of buttons. It also changes the bg color of the delete button. The updates include:
colors.css. I did this to prevent mismatched button colors. Self-hosted clients could get green and blue buttons at the same time. This happens if they update cspace-input but not cspace-ui. This is a rare edge case and the plan is to delete cspace-input but this fix keeps things safe until then.Why are we doing this? (with JIRA link)
https://collectionspace.atlassian.net/browse/DRYD-1925
How should this be tested? Do these changes have associated tests?
The collectionspace/cspace-input.js#26 is a dependency and should first be merged and published. If you want to test it before, you can still do that by running a
npm install cspace-input@file:{path-to-local-cspace-input}after pulling and building the cspace-input PR locally. After that you can:Dependencies for merging? Releasing to production?
The collectionspace/cspace-input.js#26 should be first merged and published.
Has the application documentation been updated for these changes?
Changelog has been updated
Did someone actually run this code to verify it works?
@spirosdi ran it locally
Have any new accessibility violations been handled?
no new a11y violations