🤖 feat: add custom model parameter override fields to custom model editing

src/browser/features/Settings/Sections/ModelRow.tsx

@@ -179,6 +179,9 @@ export interface ModelRowProps {
   editModelValue?: string;
   editContextValue?: string;
   editMappedToModel?: string;
+  editMaxOutputTokensValue?: string;
+  editTemperatureValue?: string;
+  editTopPValue?: string;
   editAutofocus?: "model" | "context";
   customContextWindowTokens?: number | null;
   mappedToModel?: string | null;
@@ -211,6 +214,9 @@ export interface ModelRowProps {
   onEditModelChange?: (value: string) => void;
   onEditContextChange?: (value: string) => void;
   onEditMappedToModelChange?: (value: string) => void;
+  onEditMaxOutputTokensChange?: (value: string) => void;
+  onEditTemperatureChange?: (value: string) => void;
+  onEditTopPChange?: (value: string) => void;
   onRemove?: () => void;
   /** Set/clear explicit route override (null = auto) */
   onSetRouteOverride?: (route: string | null) => void;
@@ -332,6 +338,52 @@ export function ModelRow(props: ModelRowProps) {
                 />
               </div>
             )}
+            {props.isCustom && (
+              <div className="mt-1.5 flex items-center gap-2">
+                <span className="text-muted w-16 shrink-0 text-xs md:w-20">Params</span>
+                <div className="grid min-w-0 flex-1 grid-cols-3 gap-1.5">
+                  <input
+                    type="text"
+                    inputMode="numeric"
+                    value={props.editMaxOutputTokensValue ?? ""}
+                    onChange={(e) => props.onEditMaxOutputTokensChange?.(e.target.value)}
+                    onKeyDown={createEditKeyHandler({
+                      onSave: () => props.onSaveEdit?.(),
+                      onCancel: () => props.onCancelEdit?.(),
+                    })}
+                    className="bg-modal-bg border-border-medium focus:border-accent min-w-0 rounded border px-2 py-0.5 text-right font-mono text-xs focus:outline-none"
+                    placeholder="max_output_tokens"
+                    title="max_output_tokens"
+                  />
+                  <input
+                    type="text"
+                    inputMode="decimal"
+                    value={props.editTemperatureValue ?? ""}
+                    onChange={(e) => props.onEditTemperatureChange?.(e.target.value)}
+                    onKeyDown={createEditKeyHandler({
+                      onSave: () => props.onSaveEdit?.(),
+                      onCancel: () => props.onCancelEdit?.(),
+                    })}
+                    className="bg-modal-bg border-border-medium focus:border-accent min-w-0 rounded border px-2 py-0.5 text-right font-mono text-xs focus:outline-none"
+                    placeholder="temperature"
+                    title="temperature"
+                  />
+                  <input
+                    type="text"
+                    inputMode="decimal"
+                    value={props.editTopPValue ?? ""}
+                    onChange={(e) => props.onEditTopPChange?.(e.target.value)}
+                    onKeyDown={createEditKeyHandler({
+                      onSave: () => props.onSaveEdit?.(),
+                      onCancel: () => props.onCancelEdit?.(),
+                    })}
+                    className="bg-modal-bg border-border-medium focus:border-accent min-w-0 rounded border px-2 py-0.5 text-right font-mono text-xs focus:outline-none"
+                    placeholder="top_p"
+                    title="top_p"
+                  />
+                </div>
+              </div>
+            )}
           </div>
           {props.editError && <div className="text-error mt-1 text-xs">{props.editError}</div>}
         </td>

src/browser/features/Settings/Sections/ModelsSection.test.ts

@@ -1,6 +1,14 @@
 import { describe, expect, test } from "bun:test";
 import { KNOWN_MODELS } from "@/common/constants/knownModels";
-import { shouldAllowRouteOverrideInSettings, shouldShowModelInSettings } from "./ModelsSection";
+import {
+  buildUpdatedModelParameters,
+  migrateModelParameterEntry,
+  parseBoundedNumberInput,
+  parsePositiveIntegerInput,
+  removeModelParameterEntry,
+  shouldAllowRouteOverrideInSettings,
+  shouldShowModelInSettings,
+} from "./ModelsSection";
 
 describe("shouldShowModelInSettings", () => {
   test("hides OAuth-required Codex model when OpenAI OAuth is not configured", () => {
@@ -45,3 +53,125 @@ describe("shouldAllowRouteOverrideInSettings", () => {
     expect(shouldAllowRouteOverrideInSettings("ollama:gpt-oss:20b")).toBe(true);
   });
 });
+
+describe("model parameter edit helpers", () => {
+  test("parses positive integer input for max_output_tokens", () => {
+    expect(parsePositiveIntegerInput("42")).toBe(42);
+    expect(parsePositiveIntegerInput("0")).toBeNull();
+    expect(parsePositiveIntegerInput("1.5")).toBeNull();
+    expect(parsePositiveIntegerInput("abc")).toBeNull();
+  });
+
+  test("parses bounded decimal input for temperature and top_p", () => {
+    expect(parseBoundedNumberInput("0", 0, 2)).toBe(0);
+    expect(parseBoundedNumberInput("1.5", 0, 2)).toBe(1.5);
+    expect(parseBoundedNumberInput("2", 0, 2)).toBe(2);
+    expect(parseBoundedNumberInput("2.1", 0, 2)).toBeNull();
+    expect(parseBoundedNumberInput("-0.1", 0, 1)).toBeNull();
+  });
+
+  test("buildUpdatedModelParameters preserves non-editable parameters when clearing editable fields", () => {
+    const updated = buildUpdatedModelParameters(
+      {
+        "gpt-5": {
+          max_output_tokens: 1024,
+          temperature: 0.7,
+          top_k: 42,
+        },
+      },
+      "gpt-5",
+      {
+        max_output_tokens: null,
+        temperature: null,
+        top_p: null,
+      }
+    );
+
+    expect(updated).toEqual({
+      "gpt-5": {
+        top_k: 42,
+      },
+    });
+  });
+
+  test("buildUpdatedModelParameters updates editable fields", () => {
+    const withNewOverrides = buildUpdatedModelParameters(undefined, "renamed", {
+      max_output_tokens: 2048,
+      temperature: 0.5,
+      top_p: null,
+    });
+
+    expect(withNewOverrides).toEqual({
+      renamed: {
+        max_output_tokens: 2048,
+        temperature: 0.5,
+      },
+    });
+  });
+
+  test("rename migration preserves non-editable overrides and removes legacy key", () => {
+    const migrated = migrateModelParameterEntry(
+      {
+        legacy: {
+          temperature: 0.2,
+          top_k: 42,
+          seed: 7,
+        },
+      },
+      "legacy",
+      "renamed"
+    );
+
+    const updated = buildUpdatedModelParameters(migrated, "renamed", {
+      max_output_tokens: null,
+      temperature: 0.8,
+      top_p: null,
+    });
+
+    expect(updated).toEqual({
+      renamed: {
+        temperature: 0.8,
+        top_k: 42,
+        seed: 7,
+      },
+    });
+  });
+
+  test("rename migration merges existing destination overrides", () => {
+    const migrated = migrateModelParameterEntry(
+      {
+        legacy: {
+          temperature: 0.4,
+          top_k: 12,
+        },
+        renamed: {
+          seed: 99,
+        },
+      },
+      "legacy",
+      "renamed"
+    );
+
+    expect(migrated).toEqual({
+      renamed: {
+        seed: 99,
+        temperature: 0.4,
+        top_k: 12,
+      },
+    });
+  });
+
+  test("removeModelParameterEntry clears old model parameter keys", () => {
+    const withoutLegacy = removeModelParameterEntry(
+      {
+        legacy: { temperature: 0.2 },
+        renamed: { top_p: 0.8 },
+      },
+      "legacy"
+    );
+
+    expect(withoutLegacy).toEqual({
+      renamed: { top_p: 0.8 },
+    });
+  });
+});