🤖 feat: add custom model parameter override fields to custom model editing by Neppkun · Pull Request #3453 · coder/mux

Neppkun · 2026-06-04T17:57:32Z

Summary

Adds max_output_tokens, temperature, and top_p editing to the Custom Models edit flow in Settings, so users can configure per-model provider overrides in-app instead of editing ~/.mux/providers.jsonc manually.

Background

providers.jsonc already supports per-model parameter overrides and runtime consumption, but the Settings UI had no controls for these fields. This expands on #2743 by exposing those existing capabilities in the custom model editing UX.

Implementation

Added modelParameters to provider config payloads returned to the UI.
Added a new typed provider mutation: providers.setModelParameters for setting/clearing per-model overrides.
Extended ProviderService to:
- surface filtered modelParameters in getConfig
- persist/clear overrides at provider.modelParameters[modelId]
- remove empty entries/maps when cleared
Extended custom model editing UI (ModelsSection + ModelRow) to:
- show edit fields for max_output_tokens, temperature, top_p
- validate ranges (>0 int, 0..2, 0..1)
- save overrides along with model metadata updates
- clear stale override entries when model IDs are renamed

Demo

https://owo.whats-th.is/4nedYg5.mp4

Validation

make typecheck
bun test src/node/services/providerService.test.ts src/browser/features/Settings/Sections/ModelsSection.test.ts
Attempted make static-check in this environment, but it is blocked by missing local tools: shfmt, shellcheck, and hadolint.

Risks

Main risk is save sequencing when both model metadata and model-parameter overrides are updated in one edit operation.
Mitigated by targeted service/UI helper tests and by falling back to config refresh on mutation failures.

Generated with mux • Model: openai:gpt-5.3-codex • Thinking: high • Cost: $4.54

Neppkun · 2026-06-04T17:58:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1870af287e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Neppkun · 2026-06-04T18:13:11Z

Addressed Codex findings in a follow-up commit (a1c80adfc):

discussion_r3357996320 (preserve non-editable parameters when clearing UI fields)
- Updated ProviderService.setModelParameters to remove only editable keys (max_output_tokens, temperature, top_p) and keep any remaining passthrough/non-editable keys when the model is still configured.
- Added regression test: clears editable keys without dropping non-editable model parameters.
discussion_r3357996326 (clear overrides when removing custom models)
- Updated custom model remove flow in ModelsSection to clear the matching model-parameter entry (optimistic + persisted cleanup call to setModelParameters with null overrides after model removal).
- Added helper coverage for removing model-parameter entries.
discussion_r3357996329 (do not drop all overrides because one entry is malformed)
- Hardened normalizeModelParameters to recover valid per-model entries when the full object parse fails.
- Added regression test: retains valid model parameter entries when another entry is malformed.

Validation run:

make typecheck
bun test src/node/services/providerService.test.ts src/browser/features/Settings/Sections/ModelsSection.test.ts

Neppkun · 2026-06-04T18:13:34Z

@codex review

Addressed all prior findings and resolved those threads; please re-review.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1c80adfc1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Neppkun · 2026-06-04T18:59:56Z

Addressed new Codex finding discussion_r3358046353 in commit 8c715feb0.

Added migrateModelParameterEntry(...) in ModelsSection and used it in rename flow so legacy non-editable overrides (e.g. top_k, seed) are migrated to the renamed model key before legacy cleanup.
Kept editable-field update/clear semantics intact via existing buildUpdatedModelParameters(...) behavior.
Added helper tests:
- rename preserves non-editable overrides and removes legacy key
- rename merge behavior when destination key already exists

Validation:

bun test src/browser/features/Settings/Sections/ModelsSection.test.ts
make typecheck

Neppkun · 2026-06-04T19:00:35Z

@codex review

Addressed the latest finding about preserving hidden parameter overrides on model rename and resolved that thread. Please re-review.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c715feb0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T19:06:20Z

+      const setOverridesResult = await api.providers.setModelParameters({
+        provider: providerId,
+        modelId: trimmedModelId,
+        overrides,
+      });


Preserve extra overrides when persisting renames

When a custom model with hand-edited modelParameters such as top_k or seed is renamed in Settings, the optimistic state migrates those extra keys, but the persisted API sequence does not: this call only sends the three editable fields for the new ID, and the later legacy clear removes the old unconfigured entry entirely. After refresh/restart, the non-editable overrides are lost despite being preserved in the temporary UI state; persist the migrated entry or add a backend rename path before clearing the legacy key.

Useful? React with 👍 / 👎.

Neppkun · 2026-06-04T19:27:18Z

Addressed the rename persistence bug in commit 29845a7.

Fix summary

Added renameFromModelId to providers.setModelParameters so backend can atomically migrate model-parameter entries during rename.
Updated ProviderService.setModelParameters to migrate and merge the source entry into the destination before applying editable overrides, preserving non-editable keys (e.g. top_k, seed).
Updated the Settings save flow to send renameFromModelId instead of issuing a separate legacy-clear call.
Added/updated regression test coverage for rename + non-editable key preservation.

Validation:

bun test src/node/services/providerService.test.ts src/browser/features/Settings/Sections/ModelsSection.test.ts
make typecheck

@codex review

chatgpt-codex-connector · 2026-06-04T19:27:26Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Neppkun · 2026-06-04T19:27:58Z

oh ok

feat: add custom model parameter overrides in settings

1870af2

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread src/node/services/providerService.ts Outdated

Comment thread src/browser/features/Settings/Sections/ModelsSection.tsx

Comment thread src/node/services/providerService.ts

fix: address codex review for model parameter overrides

a1c80ad

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread src/browser/features/Settings/Sections/ModelsSection.tsx Outdated

Preserve model parameter overrides when renaming models

8c715fe

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Preserve modelParameters on custom model rename

29845a7

Conversation

Neppkun commented Jun 4, 2026

Summary

Background

Implementation

Demo

Validation

Risks

Uh oh!

Neppkun commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Neppkun commented Jun 4, 2026

Uh oh!

Neppkun commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Neppkun commented Jun 4, 2026

Uh oh!

Neppkun commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Neppkun commented Jun 4, 2026

Fix summary

Uh oh!

chatgpt-codex-connector Bot commented Jun 4, 2026

Uh oh!

Neppkun commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant