Skip to content

fix: Prevent DivisionByZeroError in BaseHandler::reproportion() with float 0.0 #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gr8man wants to merge 2 commits into
base: develop
Choose a base branch
from
+35 −13
Open

fix: Prevent DivisionByZeroError in BaseHandler::reproportion() with float 0.0 #10319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04a7ae4
Fix division by zero when origWidth or origHeight is float 0.0 in Bas…
gr8man Jun 17, 2026
9869004
Refine reproportion() logic
gr8man Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions system/Images/Handlers/BaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,29 +720,29 @@ public function __call(string $name, array $args = [])
*/
protected function reproportion()
{
if (($this->width === 0 && $this->height === 0) || $this->image()->origWidth === 0 || $this->image()->origHeight === 0 || (! ctype_digit((string) $this->width) && ! ctype_digit((string) $this->height)) || ! ctype_digit((string) $this->image()->origWidth) || ! ctype_digit((string) $this->image()->origHeight)) {
$image = $this->image();
$origW = (int) $image->origWidth;
$origH = (int) $image->origHeight;
$w = (int) $this->width;
$h = (int) $this->height;

if (! is_numeric($this->width) || ! is_numeric($this->height) || $origW === 0 || $origH === 0 || ($w === 0 && $h === 0)) {
return;
}

// Sanitize
$this->width = (int) $this->width;
$this->height = (int) $this->height;
$this->width = $w;
$this->height = $h;

if ($this->masterDim !== 'width' && $this->masterDim !== 'height') {
if ($this->width > 0 && $this->height > 0) {
$this->masterDim = ((($this->image()->origHeight / $this->image()->origWidth) - ($this->height / $this->width)) < 0) ? 'width' : 'height';
} else {
$this->masterDim = ($this->height === 0) ? 'width' : 'height';
}
} elseif (($this->masterDim === 'width' && $this->width === 0) || ($this->masterDim === 'height' && $this->height === 0)
) {
$this->masterDim = ($h === 0 || ($w > 0 && (($origH / $origW) - ($h / $w) < 0))) ? 'width' : 'height';
} elseif (($this->masterDim === 'width' && $w === 0) || ($this->masterDim === 'height' && $h === 0)) {
return;
}

if ($this->masterDim === 'width') {
$this->height = (int) ceil($this->width * $this->image()->origHeight / $this->image()->origWidth);
$this->height = (int) ceil($w * $origH / $origW);
} else {
$this->width = (int) ceil($this->image()->origWidth * $this->height / $this->image()->origHeight);
$this->width = (int) ceil($origW * $h / $origH);
}
}

Expand Down
22 changes: 22 additions & 0 deletions tests/system/Images/BaseHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
use CodeIgniter\Test\CIUnitTestCase;
use org\bovigo\vfs\vfsStream;
use PHPUnit\Framework\Attributes\Group;
use ReflectionMethod;

/**
* Test the common image processing functionality.
Expand Down Expand Up @@ -130,4 +131,25 @@ public function testImageHandled(): void
$handler->withFile($this->path);
$this->assertSame($this->path, $handler->getPathname());
}

public function testReproportionWithFloatZero(): void
{
$handler = Services::image('gd', null, false);
$handler->withFile($this->path);

$image = $handler->getFile();
$image->origWidth = 0.0;
$image->origHeight = 0.0;

// Use reflection to test the protected method reproportion directly
// This should not throw a DivisionByZeroError
$expectedWidth = $handler->getWidth();
$expectedHeight = $handler->getHeight();

$method = new ReflectionMethod($handler::class, 'reproportion');
$method->invoke($handler);

$this->assertSame($expectedWidth, $handler->getWidth());
$this->assertSame($expectedHeight, $handler->getHeight());
}
}
Loading