fix: Prevent DivisionByZeroError in BaseHandler::reproportion() with float 0.0#10319
Open
gr8man wants to merge 2 commits into
Open
fix: Prevent DivisionByZeroError in BaseHandler::reproportion() with float 0.0#10319gr8man wants to merge 2 commits into
gr8man wants to merge 2 commits into
Conversation
…eHandler::reproportion() and add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential
DivisionByZeroErrorinsideBaseHandler::reproportion()when processing image resizing operations where dimensions (origWidthororigHeight) might evaluate to0.0(float) or when provided dimensions are invalid.Previously, the strict comparison check
=== 0on float0.0allowed the execution to pass through the initial guard clause, causing a crash during proportion calculations.Changes:
reproportion()to safely cast inputs tointand centralize dimension validation.is_numeric()to ensure both provided and original dimensions are mathematically valid.testReproportionWithFloatZeroinBaseHandlerTestutilizing Reflection to directly test the protected method's early return behavior without side effects.Checklist: