Skip to content

⚡️ Speed up method OneNoteDataSource.users_onenote_delete_sections by 6% #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method OneNoteDataSource.users_onenote_delete_sections by 6% #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 41 additions & 41 deletions backend/python/app/sources/external/microsoft/one_note/one_note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


import json
import logging
from dataclasses import asdict
Expand Down Expand Up @@ -111,29 +109,29 @@ def _handle_onenote_response(self, response: object) -> OneNoteResponse:
if response is None:
return OneNoteResponse(success=False, error="Empty response from OneNote API")

success = True
error_msg = None
# Fast-path: dictionary with 'error'
if isinstance(response, dict):
if 'error' in response:
error_info = response['error']
if isinstance(error_info, dict):
msg = f"{error_info.get('code', 'Unknown')}: {error_info.get('message', 'No message')}"
return OneNoteResponse(success=False, data=response, error=msg)
else:
return OneNoteResponse(success=False, data=response, error=str(error_info))
return OneNoteResponse(success=True, data=response, error=None)

# Fast-path: object with 'error'

# Enhanced error response handling for OneNote
if hasattr(response, 'error'):
success = False
error_msg = str(response.error)
elif isinstance(response, dict) and 'error' in response:
success = False
error_info = response['error']
if isinstance(error_info, dict):
error_msg = f"{error_info.get('code', 'Unknown')}: {error_info.get('message', 'No message')}"
else:
error_msg = str(error_info)
elif hasattr(response, 'code') and hasattr(response, 'message'):
success = False
error_msg = f"{response.code}: {response.message}"
return OneNoteResponse(success=False, data=response, error=str(response.error))

return OneNoteResponse(
success=success,
data=response,
error=error_msg,
)
# Fast-path: object with 'code' and 'message'
if hasattr(response, 'code') and hasattr(response, 'message'):
return OneNoteResponse(success=False, data=response, error=f"{response.code}: {response.message}")

# Default: assume success
return OneNoteResponse(success=True, data=response, error=None)
except Exception as e:
logger.error(f"Error handling OneNote response: {e}")
return OneNoteResponse(success=False, error=str(e))
Expand Down Expand Up @@ -17668,31 +17666,33 @@ async def users_onenote_delete_sections(
try:
# Use typed query parameters
query_params = RequestConfiguration()
# Set query parameters using typed object properties
if select:
query_params.select = select if isinstance(select, list) else [select]
if expand:
query_params.expand = expand if isinstance(expand, list) else [expand]
if filter:
query_params.filter = filter
if orderby:
query_params.orderby = orderby
if search:
query_params.search = search
config = RequestConfiguration()
qp = query_params # local alias for readability

# Inlined all OData parameter assignments (null check only)
if select is not None:
qp.select = select if isinstance(select, list) else [select]
if expand is not None:
qp.expand = expand if isinstance(expand, list) else [expand]
if filter is not None:
qp.filter = filter
if orderby is not None:
qp.orderby = orderby
if search is not None:
qp.search = search
if top is not None:
query_params.top = top
qp.top = top
if skip is not None:
query_params.skip = skip
qp.skip = skip

# Create proper typed request configuration
config = RequestConfiguration()
config.query_parameters = query_params
config.query_parameters = qp

if headers:
config.headers = headers
# Only copy headers if present; mutate only as needed
if headers is not None:
config.headers = headers.copy() if isinstance(headers, dict) else headers

# Add consistency level for search operations in OneNote
if search:
# OneNote search consistency header
if search is not None:
if not config.headers:
config.headers = {}
config.headers['ConsistencyLevel'] = 'eventual'
Expand Down