drpcserver: add Stop(), listener and conn tracking#40
Draft
cthumuluru-crdb wants to merge 2 commits intocockroachdb:mainfrom
Draft
drpcserver: add Stop(), listener and conn tracking#40cthumuluru-crdb wants to merge 2 commits intocockroachdb:mainfrom
cthumuluru-crdb wants to merge 2 commits intocockroachdb:mainfrom
Conversation
Add gRPC-like lifecycle management to the DRPC server: - Track listeners passed to Serve and close them in Stop() - Track server-side connections and close them in Stop() - Add Stop() method that closes all listeners and connections This mirrors grpc.Server behavior where Stop() forcefully terminates all active connections and closes all listeners. Co-Authored-By: roachdev-claude roachdev-claude-bot@cockroachlabs.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add gRPC-like lifecycle management to the DRPC server:
This mirrors grpc.Server behavior where Stop() forcefully terminates
all active connections and closes all listeners.
Co-Authored-By: roachdev-claude roachdev-claude-bot@cockroachlabs.com