rpc,server: add DRPC server Stop() for graceful shutdown during drain#166526
Draft
cthumuluru-crdb wants to merge 1 commit intocockroachdb:masterfrom
Draft
rpc,server: add DRPC server Stop() for graceful shutdown during drain#166526cthumuluru-crdb wants to merge 1 commit intocockroachdb:masterfrom
cthumuluru-crdb wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Add a Stop() method to the DRPCServer interface that closes all tracked listeners and forcefully closes active connections, mirroring grpc.Server.Stop(). Call it during drain and register it as a stopper closer to ensure DRPC connections are properly cleaned up on shutdown. Also add a nil guard in IsConnectionRejected to prevent panics, and update the DRPC dependency to include Stop() support. Resolves: cockroachdb#165377 Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
|
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Stacked on top of cockroachdb/drpc#40.
Add a Stop() method to the DRPCServer interface that closes all tracked listeners and forcefully closes active connections, mirroring grpc.Server.Stop(). Call it during drain and register it as a stopper closer to ensure DRPC connections are properly cleaned up on shutdown.
Also add a nil guard in IsConnectionRejected to prevent panics, and update the DRPC dependency to include Stop() support.
Resolves: #165377
Release note: None