Dev v3 amanabiy pages #4136

amanabiy · 2025-12-30T09:56:51Z

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov · 2025-12-30T10:59:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (0f8232f) to head (112b41b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4136   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         878      878           
  Lines       25716    25716           
  Branches     9297     9297           
=======================================
  Hits        24985    24985           
  Misses        725      725           
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

scripts/setup-build-tools.js

+
+function execCommand(command, options = {}) {
+  try {
+    execSync(command, { stdio: 'inherit', ...options });


Generally, the problem is fixed by avoiding concatenating environment-derived values into a shell command string executed via a shell. Instead, call the program directly and pass arguments as an array using child_process.execFileSync or spawnSync, so the shell doesn’t reinterpret special characters. If dynamic construction is unavoidable, inputs must be safely escaped—but that is error-prone and unnecessary here.

In this specific file, we should:

Replace execSync(command, ...) with execFileSync using a command binary and an arguments array.

Stop passing full shell command strings like mkdir -p ${copyBuildToolsPath} into execCommand. Instead, call execCommand with a command name and a list of arguments, e.g. execCommand('mkdir', ['-p', copyBuildToolsPath]).

Update execCommand to accept (cmd, args = [], options = {}), log a human-readable representation, and pass those directly to execFileSync.

Keep functionality identical: still run mkdir -p <path>, rm -rf <path>, and git clone --branch ... with the same options and error logging.

Concretely in scripts/setup-build-tools.js:

Add execFileSync to the import from child_process.

Change the three top-level execCommand calls on lines 17–19 to use (command, args) instead of a single string.

Rewrite execCommand on lines 23–33 accordingly, and update error messages to print the reconstructed command string for readability.

pan-kot · 2026-01-16T16:19:04Z

scripts/setup-build-tools.js

+// SPDX-License-Identifier: Apache-2.0
+
+// Can be used in postinstall script like so:
+// "postinstall": "node ./scripts/install-peer-dependency.js collection-hooks:property-filter-token-groups"


this description is a leftover, I believe we don't need any for this script as all

pan-kot · 2026-01-16T16:23:58Z

scripts/setup-build-tools.js

+const copyBuildToolsPath = path.join(process.cwd(), 'shared', 'build-tools');
+execCommand(`mkdir -p ${copyBuildToolsPath}`);
+execCommand(`rm -rf ${copyBuildToolsPath}`);
+execCommand(`git clone --branch ${branch} --single-branch ${targetRepository} ${copyBuildToolsPath}`);


For such a simple command - can we inline that in the package.json?

E.g. "rimraf shared/build-tools && mkdir -p shared/build-tools && git clone --branch add-test-pages-util-permutation-view --single-branch https://github.com/cloudscape-design/build-tools.git shared/build-tools"

pan-kot · 2026-01-16T16:24:33Z

pages/alert/permutations.page.tsx

-        <PermutationsView permutations={permutations} render={permutation => <Alert {...permutation} />} />
+        <PermutationsView
+          permutations={permutations}
+          render={(permutation: AlertProps) => <Alert {...permutation} />}


why the param is explicitly annotated here - it is necessary?

pan-kot · 2026-01-16T16:25:14Z

package.json

    "@babel/plugin-syntax-typescript": "^7.23.3",
    "@cloudscape-design/browser-test-tools": "^3.0.0",
-    "@cloudscape-design/build-tools": "github:cloudscape-design/build-tools#main",
+    "@cloudscape-design/build-tools-repo": "github:cloudscape-design/build-tools#add-test-pages-util-permutation-view",


what is @cloudscape-design/build-tools-repo for?

amanabiy deployed to dev-pages-react16 December 30, 2025 10:59 — with GitHub Actions View deployment

amanabiy deployed to dev-pages-react18 December 30, 2025 10:59 — with GitHub Actions View deployment

amanabiy deployed to dev-pages-react16 December 30, 2025 14:04 — with GitHub Actions View deployment

amanabiy deployed to dev-pages-react18 December 30, 2025 14:04 — with GitHub Actions View deployment

amanabiy force-pushed the dev-v3-amanabiy-pages branch from cb18531 to 8b1eafe Compare January 13, 2026 14:58

amanabiy deployed to dev-pages-react16 January 13, 2026 15:08 — with GitHub Actions View deployment

amanabiy deployed to dev-pages-react18 January 13, 2026 15:08 — with GitHub Actions View deployment

feat: allow consuming permutations view from build-tools

112b41b

amanabiy force-pushed the dev-v3-amanabiy-pages branch from 8b1eafe to 112b41b Compare January 16, 2026 15:26

github-advanced-security bot found potential problems Jan 16, 2026

View reviewed changes

amanabiy mentioned this pull request Jan 16, 2026

feat: Add test pages util permutation view cloudscape-design/build-tools#23

Open

amanabiy deployed to dev-pages-react16 January 16, 2026 15:36 — with GitHub Actions View deployment

amanabiy deployed to dev-pages-react18 January 16, 2026 15:36 — with GitHub Actions View deployment

pan-kot reviewed Jan 16, 2026

View reviewed changes

@@ -6,7 +6,7 @@
             // "postinstall": "node ./scripts/install-peer-dependency.js collection-hooks:property-filter-token-groups"
             // where "collection-hooks" is the package to fetch and "property-filter-token-groups" is the branch name in GitHub.
-            import { execSync } from 'child_process';
+            import { execFileSync } from 'child_process';
             import process from 'node:process';
             import path from 'path';
@@ -14,17 +14,18 @@
             const packageName = 'build-tools';
             const targetRepository = `https://github.com/cloudscape-design/${packageName}.git`;
             const copyBuildToolsPath = path.join(process.cwd(), 'shared', 'build-tools');
-            execCommand(`mkdir -p ${copyBuildToolsPath}`);
-            execCommand(`rm -rf ${copyBuildToolsPath}`);
-            execCommand(`git clone --branch ${branch} --single-branch ${targetRepository} ${copyBuildToolsPath}`);
+            execCommand('mkdir', ['-p', copyBuildToolsPath]);
+            execCommand('rm', ['-rf', copyBuildToolsPath]);
+            execCommand('git', ['clone', '--branch', branch, '--single-branch', targetRepository, copyBuildToolsPath]);
             console.log(`build-tools has been successfully installed!`);
-            function execCommand(command, options = {}) {
+            function execCommand(command, args = [], options = {}) {
               try {
-                execSync(command, { stdio: 'inherit', ...options });
+                execFileSync(command, args, { stdio: 'inherit', ...options });
               } catch (error) {
-                console.error(`Error executing command: ${command}`);
+                const commandString = [command, ...args].join(' ');
+                console.error(`Error executing command: ${commandString}`);
                 console.error(`Error message: ${error.message}`);
                 console.error(`Stdout: ${error.stdout && error.stdout.toString()}`);
                 console.error(`Stderr: ${error.stderr && error.stderr.toString()}`);

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dev v3 amanabiy pages #4136

Dev v3 amanabiy pages #4136

Uh oh!

amanabiy commented Dec 30, 2025

Uh oh!

codecov bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

Check warning

Copilot Autofix

pan-kot Jan 16, 2026

Uh oh!

pan-kot Jan 16, 2026

Uh oh!

pan-kot Jan 16, 2026

Uh oh!

pan-kot Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dev v3 amanabiy pages #4136

Are you sure you want to change the base?

Dev v3 amanabiy pages #4136

Uh oh!

Conversation

amanabiy commented Dec 30, 2025

Description

How has this been tested?

Correctness

Security

Testing

Uh oh!

codecov bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Check warning

Uh oh!

Copilot Autofix

pan-kot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

pan-kot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

pan-kot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

pan-kot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Dec 30, 2025 •

edited

Loading