Skip to content

feat: Add test pages util permutation view#23

Closed
amanabiy wants to merge 15 commits intomainfrom
add-test-pages-util-permutation-view
Closed

feat: Add test pages util permutation view#23
amanabiy wants to merge 15 commits intomainfrom
add-test-pages-util-permutation-view

Conversation

@amanabiy
Copy link
Copy Markdown
Member

@amanabiy amanabiy commented Dec 30, 2025

Description

This PR enables direct consumption of the pre-built build-tools package from GitHub, eliminating the need for consumers to build it locally. A pre-push hook ensures the build artifacts are always up-to-date before publishing.

How is it tested

Backward compatibility: Tested by consuming this branch in an existing repository to verify no breaking changes
Follow-up PR demonstrates usage with the new PermutationsView component in chat-components Draft PR, and Components Draft PR

Build verification: Pre-push hook validates that build artifacts are current before each push

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 92.19858% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.19%. Comparing base (9a4ca5c) to head (1d3d7d8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/stylelint/no-implicit-descendant.js 91.42% 3 Missing ⚠️
src/dev-pages-utils/permutations-view.tsx 85.71% 2 Missing ⚠️
src/stylelint/license-headers.js 92.30% 2 Missing ⚠️
src/stylelint/no-motion-outside-of-mixin.js 90.00% 2 Missing ⚠️
src/stylelint/z-index-value-constraint.js 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main      #23       +/-   ##
=========================================
+ Coverage      0   92.19%   +92.19%     
=========================================
  Files         0        7        +7     
  Lines         0      141      +141     
  Branches      0       40       +40     
=========================================
+ Hits          0      130      +130     
- Misses        0       11       +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanabiy amanabiy force-pushed the add-test-pages-util-permutation-view branch from e17e4e8 to cfa62cc Compare January 9, 2026 16:21
@amanabiy amanabiy changed the title Add test pages util permutation view feat: Add test pages util permutation view Jan 9, 2026
@amanabiy amanabiy force-pushed the add-test-pages-util-permutation-view branch 2 times, most recently from f1a8ef0 to 1b6a4e7 Compare January 9, 2026 17:50
@amanabiy amanabiy force-pushed the add-test-pages-util-permutation-view branch from 1b6a4e7 to 894193f Compare January 9, 2026 17:53
@amanabiy amanabiy force-pushed the add-test-pages-util-permutation-view branch 2 times, most recently from 9d11ee9 to d314e85 Compare January 13, 2026 15:11
@amanabiy amanabiy force-pushed the add-test-pages-util-permutation-view branch 5 times, most recently from 296f8b7 to 6a2edd0 Compare January 16, 2026 10:09
@amanabiy amanabiy force-pushed the add-test-pages-util-permutation-view branch from 6a2edd0 to 348272c Compare January 16, 2026 10:15
@amanabiy amanabiy requested a review from pan-kot January 16, 2026 10:17
Comment thread package.json Outdated
Comment on lines +7 to +14
"./lib/dev-pages-utils": {
"types": "./lib/dev-pages-utils/index.d.ts",
"default": "./lib/dev-pages-utils/index.js"
},
"./dev-pages-utils": {
"types": "./lib/dev-pages-utils/index.d.ts",
"default": "./lib/dev-pages-utils/index.js"
},
Copy link
Copy Markdown
Member Author

@amanabiy amanabiy Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated package exports to support both ./dev-pages-utils and ./lib/dev-pages-utils path to support for typescript for <5.0 and bundlers like vite that need explicit path if it is specified. You can see here that the resolvePackageJsonExports is not available before 5.0.

  • /dev-pages-utils: For TypeScript 5.0+ which properly resolves package.json exports
  • ./lib/dev-pages-utils: For TypeScript <5.0 and bundlers (Vite) that need explicit paths

@amanabiy amanabiy marked this pull request as ready for review January 16, 2026 11:12
@amanabiy amanabiy requested a review from a team as a code owner January 16, 2026 11:12
@amanabiy amanabiy force-pushed the add-test-pages-util-permutation-view branch from e13aa0a to 977902a Compare January 16, 2026 14:11
@amanabiy
Copy link
Copy Markdown
Member Author

Closed since this it has been split into two the following PRs: feat: building the build tools into /lib and feat: Add dev pages utils permutation view

@amanabiy amanabiy closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants