Remove unused statistics collection (not actually merged, please ignore)#8174
Remove unused statistics collection (not actually merged, please ignore)#8174onurctirtir merged 3 commits intobump-main-14.1develfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## bump-main-14.1devel #8174 +/- ##
=======================================================
+ Coverage 88.75% 88.91% +0.16%
=======================================================
Files 287 286 -1
Lines 63231 63101 -130
Branches 7921 7907 -14
=======================================================
- Hits 56118 56109 -9
+ Misses 4856 4734 -122
- Partials 2257 2258 +1 🚀 New features to boost your workflow:
|
|
Should remove citus_server_id() in 14.0 sql script once #8170 is merged. update: No, won't remove it as it's still indirectly used by IsWorkerTheCurrentNode(). In other words, we should still have server_id in pg_dist_node_metadata, which is generated by citus_server_id(). |
configure
Outdated
| docdir | ||
| oldincludedir | ||
| includedir | ||
| runstatedir |
There was a problem hiding this comment.
are the runstatedir changes related to this diff or an accident.
a quick search only shows the term in the configure section, so it seems unrelated, but didn't look deeply
There was a problem hiding this comment.
Not really sure why but when I revert everything and reapply the changes one by one again (i.e., do the C changes, remove libcurl & reports related bits from ac file and re-run autoreconf -f), again I got the exactly same patch, with autoconf == 2.69, which already seems to be the version we've been using based on the comments on top of configure
| * modeled after PostgreSQL's pg_random_uuid(). | ||
| */ | ||
| Datum | ||
| citus_server_id(PG_FUNCTION_ARGS) |
There was a problem hiding this comment.
moved from src/backend/distributed/utils/statistics_collection.c as is
onurctirtir
force-pushed
the
remove-stats-collector
branch
from
c7a55c8 to
0ff6e88
Compare
onurctirtir
changed the title
2 participants
DESCRIPTION: Stops on-demand statistics collection for clusters and deprecates citus.enable_statistics_collection GUC.