Skip to content

Remove unused statistics collection#8460

Merged
onurctirtir merged 8 commits intomainfrom
remove-stats-collector
Jan 19, 2026
Merged

Remove unused statistics collection#8460
onurctirtir merged 8 commits intomainfrom
remove-stats-collector

Conversation

@onurctirtir
Copy link
Copy Markdown
Member

@onurctirtir onurctirtir commented Jan 19, 2026

DESCRIPTION: Stops on-demand statistics collection for clusters and deprecates citus.enable_statistics_collection GUC.

Replaces #8174. #8174 was not actually merged, please ignore the fact that GitHub tells otherwise.

Also, this depends on some changes at #8459, so rebased on that PR.
I'll merge this to main once #8459 is merged.

* modeled after PostgreSQL's pg_random_uuid().
*/
Datum
citus_server_id(PG_FUNCTION_ARGS)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from src/backend/distributed/utils/statistics_collection.c as is

@onurctirtir onurctirtir changed the title Remove Remove unused statistics collection Jan 19, 2026
@onurctirtir onurctirtir force-pushed the remove-stats-collector branch from a474973 to 6d6f2f0 Compare January 19, 2026 13:01
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.92%. Comparing base (91342bd) to head (c87b1d1).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8460      +/-   ##
==========================================
+ Coverage   88.74%   88.92%   +0.17%     
==========================================
  Files         287      286       -1     
  Lines       63230    63101     -129     
  Branches     7920     7907      -13     
==========================================
- Hits        56113    56112       -1     
+ Misses       4859     4734     -125     
+ Partials     2258     2255       -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@onurctirtir onurctirtir requested a review from ihalatci January 19, 2026 13:32
Base automatically changed from bump-main-14.1devel to main January 19, 2026 13:34
@onurctirtir onurctirtir enabled auto-merge (squash) January 19, 2026 13:35
@onurctirtir onurctirtir merged commit 9a0228f into main Jan 19, 2026
155 of 156 checks passed
@onurctirtir onurctirtir deleted the remove-stats-collector branch January 19, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants