add tamilmani1989 to fqdn reviewer group#183
add tamilmani1989 to fqdn reviewer group#183tamilmani1989 wants to merge 1 commit intocilium:mainfrom
Conversation
Signed-off-by: Tamilmani <tamanoha@microsoft.com>
|
Cc @cilium/fqdn |
|
Thanks for your willingness to contribute and help maintain Cilium @tamilmani1989 , we'd love to see you join the group assuming the reviewer expectations are met :) I see that we're looking for @cilium/fqdn codeowners / committers feedback on this proposal. As a matter of process, it could help this proposal if you could link to example contributions or reviews to help the codeowners to see your contributions particularly in this area. Even a general link to PRs/issues authored by you (example), or individual PRs where you were heavily involved in review. If members of @cilium/fqdn are not yet comfortable in adding you to the group that approves / gets assigned reviews, then perhaps @cilium/fqdn could provide pointers as to what they'd expect to see. Even before you become part of the group, we would welcome you to continue to contribute by sending PRs to improve the area and review PRs requesting feedback from @cilium/fqdn. Every contribution you make will help to build your reputation with other contributors and give confidence that the quality bar we uphold in this area as a community will continue to be upheld with your assistance. |
|
For FQDN area in general, one thing that I expect will go a long way to demonstrating a track record would be inclusion of a major feature like the one you are actively working on. For a similar example of demonstrating the track record, you can also see this PR which highlights several bugfixes the contributor worked on which all involve quite nuanced behavior in the internals of this area of the codebase. |
|
My contributions so far: cilium/design-cfps#54 Review: |
|
Let's revisit this again in a few months after we see more regular contributions to the area. cc @cilium/fqdn |
I have been reviewing and contributing to FQDN for sometime and continue to do going forward.