Skip to content

Comments

Add Viktor to the envoy team#243

Closed
viktor-kurchenko wants to merge 1 commit intocilium:mainfrom
viktor-kurchenko:pr/vk/add/viktor
Closed

Add Viktor to the envoy team#243
viktor-kurchenko wants to merge 1 commit intocilium:mainfrom
viktor-kurchenko:pr/vk/add/viktor

Conversation

@viktor-kurchenko
Copy link

@viktor-kurchenko viktor-kurchenko commented May 23, 2025

I've joined the Envoy team recently.
Could you please add my GH account the corresponding teams?

CC: @sayboras

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@xmulligan
Copy link
Member

Can you link some of the work you have done for the Envoy team so far in the PR for reference?

@viktor-kurchenko
Copy link
Author

Can you link some of the work you have done for the Envoy team so far in the PR for reference?

Not yet, I just joined)
Should I postpone the PR?

@xmulligan
Copy link
Member

Yea, I think @joestringer has some good advice in his PR comment here #183 (comment) and the one below.

Maybe we should write this down more formally too.

@xmulligan
Copy link
Member

This isn't to discourage you from doing code reviews right now. We always want to see more contributions :)

I think the key part here comes from the reviewer expectations: "Being a Reviewer is a very significant responsibility, because Committers who merge PRs rely on the code approvals of Reviewers who are considered to be experts in their specific areas. Reviewers should not assume that Committers will also do an in-depth code review."

We want people to be able to show a history of contributions to an area before becoming a reviewer because once they are a reviewer they can approve code being merged.

@xmulligan
Copy link
Member

We are working to solve this with shadow reviewers, but haven't made progress yet, but open to any help or ideas you might have :) #230

@joestringer
Copy link
Member

Agreed, you should contribute to the area on a regular basis before becoming a reviewer for the team. I would also defer strongly to @jrajahalme's judgement here as he would have the best understanding of the understanding/knowledge necessary to uphold the code quality standards we expect in reviewing the Envoy-related code.

@viktor-kurchenko
Copy link
Author

Thank you @xmulligan and @joestringer for the explanations.
I'll re-open it later)

@xmulligan
Copy link
Member

Looking forward to having you join the team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants