Add Viktor to the envoy team#243
Add Viktor to the envoy team#243viktor-kurchenko wants to merge 1 commit intocilium:mainfrom viktor-kurchenko:pr/vk/add/viktor
Conversation
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
|
Can you link some of the work you have done for the Envoy team so far in the PR for reference? |
Not yet, I just joined) |
|
Yea, I think @joestringer has some good advice in his PR comment here #183 (comment) and the one below. Maybe we should write this down more formally too. |
|
This isn't to discourage you from doing code reviews right now. We always want to see more contributions :) I think the key part here comes from the reviewer expectations: "Being a Reviewer is a very significant responsibility, because Committers who merge PRs rely on the code approvals of Reviewers who are considered to be experts in their specific areas. Reviewers should not assume that Committers will also do an in-depth code review." We want people to be able to show a history of contributions to an area before becoming a reviewer because once they are a reviewer they can approve code being merged. |
|
We are working to solve this with shadow reviewers, but haven't made progress yet, but open to any help or ideas you might have :) #230 |
|
Agreed, you should contribute to the area on a regular basis before becoming a reviewer for the team. I would also defer strongly to @jrajahalme's judgement here as he would have the best understanding of the understanding/knowledge necessary to uphold the code quality standards we expect in reviewing the Envoy-related code. |
|
Thank you @xmulligan and @joestringer for the explanations. |
|
Looking forward to having you join the team :) |
I've joined the Envoy team recently.
Could you please add my GH account the corresponding teams?
CC: @sayboras