Skip to content

(#312) Fixes Issue with Certificate Incorrectly Being Identified as Self-Signed #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JPRuskin wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −8
Open

(#312) Fixes Issue with Certificate Incorrectly Being Identified as Self-Signed #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86186f3
(maint) Rename MyCertificate to Certificate
JPRuskin Feb 5, 2026
efa47f9
(#312) Fixes Self-Signed Misidentification
JPRuskin Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Start-C4bCcmSetup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ param(
}
)
)
process {
try {
$DefaultEap = $ErrorActionPreference
$ErrorActionPreference = 'Stop'
Start-Transcript -Path "$env:SystemDrive\choco-setup\logs\Start-C4bCcmSetup-$(Get-Date -Format 'yyyyMMdd-HHmmss').txt"
Expand Down Expand Up @@ -165,17 +165,19 @@ process {
Write-Warning "You specified $Thumbprint for use with CCM service, but the certificate is not in the required LocalMachine\TrustedPeople store!"
Write-Warning "Please place certificate with thumbprint: $Thumbprint in the LocalMachine\TrustedPeople store and re-run this step"
throw "Certificate not in correct location... exiting."
} elseif ($MyCertificate = Get-Item Cert:\LocalMachine\My\$Thumbprint -EA 0) {
} elseif ($Certificate = Get-Item Cert:\LocalMachine\My\$Thumbprint -EA 0) {
Write-Verbose "Copying certificate from 'Personal' store to 'TrustedPeople'"
Copy-CertToStore $MyCertificate
Copy-CertToStore $Certificate
} else {
Write-Verbose "Certificate has been successfully found in correct store"
$Certificate = Get-Item Cert:\LocalMachine\TrustedPeople\$Thumbprint
}
$chocoArgs += @("--package-parameters='/CertificateThumbprint=$Thumbprint'")
}
& Invoke-Choco @chocoArgs

if (-not $MyCertificate) { $MyCertificate = Get-Item Cert:\LocalMachine\My\* }

# If not specified, the installation will have generated a certificate
if (-not $Certificate) { $Certificate = Get-Item Cert:\LocalMachine\TrustedPeople\* }

Write-Host "Installing Chocolatey Central Management Website"
$chocoArgs = @('install', 'chocolatey-management-web', "--source='ChocolateyInternal'", '-y', "--package-parameters-sensitive=""'/ConnectionString:Server=Localhost\SQLEXPRESS;Database=ChocolateyManagement;User ID=$DatabaseUser;Password=$DatabaseUserPw;'""", '--no-progress')
Expand Down Expand Up @@ -215,12 +217,12 @@ process {

# Set a default value for TrustCertificate if we're using a self-signed cert
'(?<Parameter>\s+\$TrustCertificate)(?<Value>\s*=\s*\$true)?(?<Comma>,)?(?!\))' = "`${Parameter}$(
if (Test-SelfSignedCertificate -Certificate $MyCertificate) {' = $true'}
if (Test-SelfSignedCertificate -Certificate $Certificate) {' = $true'}
)`${Comma}"
}

# Create the site hosting the certificate import script on port 80
if ($MyCertificate.NotAfter -gt (Get-Date).AddYears(5)) {
if ($Certificate.NotAfter -gt (Get-Date).AddYears(5)) {
.\scripts\New-IISCertificateHost.ps1
}

Expand Down Expand Up @@ -265,7 +267,7 @@ process {
}

Write-Host "Chocolatey Central Management Setup has now completed" -ForegroundColor Green

} finally {
$ErrorActionPreference = $DefaultEap
Stop-Transcript
}
Loading