(#312) Fixes Issue with Certificate Incorrectly Being Identified as Self-Signed#314
Open
JPRuskin wants to merge 2 commits intochocolatey:mainfrom
Open
(#312) Fixes Issue with Certificate Incorrectly Being Identified as Self-Signed#314JPRuskin wants to merge 2 commits intochocolatey:mainfrom
JPRuskin wants to merge 2 commits intochocolatey:mainfrom
Conversation
Switching variable name in order to match other code style.
In some circumstances, environments were being identified as using a self-signed certificate incorrectly. I believe this was down to $MyCertificate not being set. This change should fix those scenarios.
JPRuskin
changed the title
C4bVerification-Win2022AzureEditionCore-self-signed 4 files 16 suites 15s ⏱️ Results for commit efa47f9. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Modifies the logic when a certificate was found to be in the right place such that it stores a $Certificate variable. Also changes $MyCertificate to $Certificate, to better match other scripts.
Motivation and Context
In the circumstance where the certificate was found in the right place, the script would not set $Certificate (formerly $MyCertificate) and consequently evaluate the (missing) certificate as self-signed.
Testing
Operating Systems Testing
Change Types Made
[ ] Feature / Enhancement (non-breaking change).[ ] Breaking change (fix or feature that could cause existing functionality to change).[ ] Documentation changes.Change Checklist
[ ] Requires a change to the documentation.[ ] Documentation has been updated.[ ] Tests to cover my changes, have been added.[ ] PowerShell code changes: PowerShell v3 compatibility checked?Related Issue
Fixes #312