Skip to content

Conversation

@jdavidoff26
Copy link
Collaborator

@jdavidoff26 jdavidoff26 commented Apr 9, 2025

What does this PR do?

How was the functionality tested and verified?

All steps should be completed in the order presented, and you should not move on to the next step until the previous is completed.

  • The title of each visual's html page is the same as the chart title.
  • The meta_data.json file for each visual is filled in correctly (the description is a complete sentence, and the title is the same as the visual).
  • Each visual and associated files has been minified using the npm run process-visual command.
  • Each visual was styled according to style guidelines (centered title/subtitle, uses our color scheme, etc.).
  • Each visual was approved by the lead developer.
  • Each visual was approved by the story's authors and/or stakeholders.
  • Each visual was submitted to Copy, and the resulting comments/edits have been resolved.

@jdavidoff26
Copy link
Collaborator Author

distribution-locations for review!

@Nik4002
Copy link
Collaborator

Nik4002 commented Apr 9, 2025

Could you remove any unnecessary files/code? Specifically, remove locations.csv, rename updated_locations.csv to locations.csv, and change the names in the code accordingly

@jdavidoff26
Copy link
Collaborator Author

Deleted original locations.csv and updated name of locations_updated.csv to locations.csv

Copy link
Contributor

@asteinhart asteinhart Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this folder needs to be added, is that right?

Copy link
Contributor

@asteinhart asteinhart Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you need to add a new package to npm? if not, lets remove the package.json and package-loc.json files changes on this pr pls!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ope! Sorry, I don't think I mean to add that folder nor the packages within it in the first place. Will remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants