-
Notifications
You must be signed in to change notification settings - Fork 5
Distribution locations #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Distribution locations #147
Conversation
…isualizations into distribution-locations
…o locations_updated.csv
…visualizations into distribution-locations
…visualizations into distribution-locations These can merge!
|
distribution-locations for review! |
|
Could you remove any unnecessary files/code? Specifically, remove |
|
Deleted original locations.csv and updated name of locations_updated.csv to locations.csv |
maroon-map/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think this folder needs to be added, is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you need to add a new package to npm? if not, lets remove the package.json and package-loc.json files changes on this pr pls!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ope! Sorry, I don't think I mean to add that folder nor the packages within it in the first place. Will remove
What does this PR do?
How was the functionality tested and verified?
All steps should be completed in the order presented, and you should not move on to the next step until the previous is completed.
htmlpage is the same as the chart title.meta_data.jsonfile for each visual is filled in correctly (the description is a complete sentence, and the title is the same as the visual).npm run process-visualcommand.