Issue #371: Upgrade checkstyle dependency#375
Open
ZaheerAhmadDev wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #371: Upgrade checkstyle dependency#375ZaheerAhmadDev wants to merge 1 commit intocheckstyle:masterfrom
ZaheerAhmadDev wants to merge 1 commit intocheckstyle:masterfrom
Conversation
Member
|
Thanks a lot, please fix CI |
ZaheerAhmadDev
force-pushed
the
updgrade-dependency
branch
from
a64c1d5 to
3a130db
Compare
romani
requested changes
Mar 26, 2026
pom.xml
Outdated
| <configLocation> | ||
| https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle_checks.xml | ||
| </configLocation> | ||
| <configLocation>google_checks.xml</configLocation> |
Member
There was a problem hiding this comment.
lets not dothis, as it will result in way more updates required.
ZaheerAhmadDev
force-pushed
the
updgrade-dependency
branch
from
3a130db to
d02701a
Compare
ZaheerAhmadDev
force-pushed
the
updgrade-dependency
branch
from
d02701a to
7a1f17a
Compare
Contributor
|
Ohh ! I didn't check there is a pr open on the issue . I think your pr looks good @romani i will be closing my PR. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #371:
Upgrade checkstyle dependency from 10.4 to 13.3.0
Upgrade java version from 17 to 21 also.