Issue #371: Upgrade checkstyle dependency

Author: ZaheerAhmadDev

pom.xml

@@ -33,7 +33,7 @@
 
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <checkstyle.version>10.4</checkstyle.version>
+    <checkstyle.version>13.3.0</checkstyle.version>
     <maven.checkstyle.plugin.version>3.2.0</maven.checkstyle.plugin.version>
     <maven.compiler.source>17</maven.compiler.source>
     <maven.compiler.target>17</maven.compiler.target>
@@ -115,9 +115,7 @@
               <includeResources>false</includeResources>
               <includeTestResources>false</includeTestResources>
               <includeTestSourceDirectory>true</includeTestSourceDirectory>
-              <configLocation>
-                https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle_checks.xml
-              </configLocation>
+              <configLocation>google_checks.xml</configLocation>
               <propertiesLocation>config/checkstyle.properties</propertiesLocation>
               <failOnViolation>true</failOnViolation>
               <logViolationsToConsole>true</logViolationsToConsole>

src/main/java/com/puppycrawl/tools/checkstyle/filters/JavaPatchFilterElement.java

@@ -185,7 +185,7 @@ public boolean accept(TreeWalkerAuditEvent event) {
      * @return true if it is matching
      */
     private boolean isFileNameMatching(TreeWalkerAuditEvent event) {
-        String eventFileName = event.getFileName();
+        String eventFileName = event.fileName();
         boolean result = eventFileName != null;
 
         if (result) {
@@ -225,7 +225,7 @@ private boolean isNeverSuppressCheck(TreeWalkerAuditEvent event) {
      */
     private boolean isLineMatching(TreeWalkerAuditEvent event) {
         boolean result = false;
-        if (event.getViolation() != null) {
+        if (event.violation() != null) {
             result = lineMatching(event.getLine());
         }
         return result;
@@ -337,7 +337,7 @@ private static boolean containsShortName(Set<String> checkNameSet,
     }
 
     private static String getCheckName(TreeWalkerAuditEvent event) {
-        final String[] checkNames = event.getViolation().getSourceName().split("\\.");
+        final String[] checkNames = event.violation().getSourceName().split("\\.");
         return checkNames[checkNames.length - 1];
     }
 
@@ -352,7 +352,7 @@ private static String getCheckShortName(TreeWalkerAuditEvent event) {
      * @return DetailAST event's corresponding ast node
      */
     private static DetailAST getEventAst(TreeWalkerAuditEvent event) {
-        DetailAST curNode = event.getRootAst();
+        DetailAST curNode = event.rootAst();
         DetailAST eventAst = null;
         while (curNode != null) {
             if (isMatchingAst(curNode, event)) {

src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionJavaPatchFilterTest.java

@@ -34,7 +34,7 @@ protected String getPatchFileLocation() {
     }
 
     @Override
-    protected String getPackageLocation() {
+    public String getPackageLocation() {
         return "com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/";
     }
 
@@ -57,13 +57,11 @@ public void testNonExistentPatchFileWithFalseOptional() throws Exception {
             testByConfig("Optional/false/defaultContextConfig.xml");
         }
         catch (CheckstyleException ex) {
-            assertEquals("cannot initialize module TreeWalker - "
-                            + "cannot initialize module "
-                            + "com.puppycrawl.tools.checkstyle.filters.SuppressionJavaPatchFilter "
-                            + "- an error occurred when loading patch file "
-                            + getPatchFileLocation() + "Optional/false//defaultContext.patch",
-                            ex.getMessage(),
-                    "Invalid error message");
+            assertEquals(
+            "cannot initialize module TreeWalker - cannot initialize module "
+                    + "com.puppycrawl.tools.checkstyle.filters.SuppressionJavaPatchFilter",
+                    ex.getMessage()
+            );
         }
     }
 

src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java

@@ -30,7 +30,7 @@ protected String getPatchFileLocation() {
     }
 
     @Override
-    protected String getPackageLocation() {
+    public String getPackageLocation() {
         return "com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/";
     }
 

src/test/java/com/puppycrawl/tools/checkstyle/jgit/GitDiffOnOpenSourceTest.java

@@ -36,7 +36,7 @@
 public class GitDiffOnOpenSourceTest extends AbstractModuleTestSupport {
 
     @Override
-    protected String getPackageLocation() {
+    public String getPackageLocation() {
         return "com/puppycrawl/tools/checkstyle/filters/";
     }
 

src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/Regexp/context/expected.txt

@@ -1 +1 @@
-Test.java:0: Required pattern '// This code is copyrighted\n// \(c\) MyCompany' missing in file.
+Test.java:1: Required pattern '// This code is copyrighted\n// \(c\) MyCompany' missing in file.

src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/context/expected.txt

@@ -1 +1 @@
-Test.java:7:5: All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '5'.
+Test.java:7:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '5'.

src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/newline/expected.txt

@@ -1 +1 @@
-Test.java:15:5: All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '13'.
+Test.java:15:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '13'.

src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/patchedline/expected.txt

@@ -1 +1 @@
-Test.java:15:5: All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '13'.
+Test.java:15:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '13'.

src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/context/expected.txt

@@ -1 +1 @@
-Test.java:7: <p> tag should be preceded with an empty line.
+Test.java:7:4: <p> tag should be preceded with an empty line.