Skip to content

Conversation

@hutch3232
Copy link
Contributor

If there is no objection, I'd like to eventually setup ruff linting for this project (I'll open an issue). Before that happens, a few unobjectionable (imo) changes would be to remove bare excepts and trailing whitespace (and ensure files end with one newline).

A lot of whitespace changes - easier to view if you use GitHub button to hide whitespace in the diff.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.05%. Comparing base (0976ade) to head (e46dc0b).

Files with missing lines Patch % Lines
chainladder/adjustments/bootstrap.py 0.00% 1 Missing ⚠️
chainladder/core/tests/rtest_correlation.py 0.00% 1 Missing ⚠️
chainladder/core/tests/test_triangle.py 0.00% 1 Missing ⚠️
chainladder/development/tests/rtest_clark.py 0.00% 1 Missing ⚠️
chainladder/development/tests/rtest_development.py 0.00% 1 Missing ⚠️
chainladder/development/tests/rtest_munich.py 0.00% 1 Missing ⚠️
chainladder/methods/tests/rtest_mack.py 0.00% 1 Missing ⚠️
chainladder/tails/tests/rtest_exponential.py 0.00% 1 Missing ⚠️
chainladder/utils/dask.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          85       85           
  Lines        4865     4865           
  Branches      619      619           
=======================================
  Hits         4138     4138           
  Misses        518      518           
  Partials      209      209           
Flag Coverage Δ
unittests 85.05% <57.14%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kennethshsu
Copy link
Collaborator

I think the last time that this was brought up is that the group does not want to use a linter for this project. If you are making changes to codes and want to use a linter to clean up your PR that's ok, but we do not want to choose one linter to go with for the whole project.

I'd suggest that this PR be withdrawn for now. Would you like to bring this up to the group again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants