Skip to content

feat: tree table modifications #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etimr wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: tree table modifications #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
788b0aa
tree table modifications
etimr Nov 25, 2025
3bedcce
Merge branch 'main' into d070615-genres-modifications
etimr Nov 25, 2025
414ab65
Merge branch 'main' into d070615-genres-modifications
johannes-vogel Dec 17, 2025
45d8820
Merge branch 'main' into d070615-genres-modifications
johannes-vogel Dec 30, 2025
a936af4
Merge branch 'main' into d070615-genres-modifications
etimr Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions app/appconfig/fioriSandboxConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,6 @@
"title": "Browse Books",
"targetURL": "#Books-display"
}
},
{
"id": "BrowseGenres",
"tileType": "sap.ushell.ui.tile.StaticTile",
"properties": {
"title": "Browse Genres",
"targetURL": "#Genres-display"
}
}
]
},
Expand All @@ -52,6 +44,14 @@
"targetURL": "#Authors-manage"
}
},
{
"id": "ManageGenres",
"tileType": "sap.ushell.ui.tile.StaticTile",
"properties": {
"title": "Manage Genres",
"targetURL": "#Genres-manage"
}
},
{
"id": "ManageOrders",
"tileType": "sap.ushell.ui.tile.StaticTile",
Expand Down Expand Up @@ -114,10 +114,10 @@
"url": "/admin-authors/webapp"
}
},
"BrowseGenres": {
"ManageGenres": {
"semanticObject": "Genres",
"action": "display",
"title": "Browse Genres",
"action": "manage",
"title": "Manage Genres",
"signature": {
"parameters": {
"Genre.ID": {
Expand Down
5 changes: 4 additions & 1 deletion app/genres/fiori-service.cds
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
using { sap.capire.bookshop.Genres } from '@capire/bookshop';

annotate AdminService.Genres with @odata.draft.enabled;
// needed for changing a parent
annotate AdminService.Genres with @odata.draft.bypass;
Copy link
Copy Markdown
Contributor

@johannes-vogel johannes-vogel Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean the maintenance of trees only works with bypass enabled?

Copy link
Copy Markdown
Author

@etimr etimr Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, you can CREATE, EDIT and DELETE nodes (root and child) without @odata.draft.bypass annotation, only CUT/PASTE (changing a parent with @odata.bind) doesn't work without @odata.draft.bypass, because we are modifying an active entity directly.

Copy link
Copy Markdown
Contributor

@johannes-vogel johannes-vogel Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we wait until the next release and then use cds.fiori.direct_crud to enable it globally.

Copy link
Copy Markdown
Author

@etimr etimr Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot be merged yet because of https://github.tools.sap/cap/cdsnode/issues/2503#issuecomment-18095257


annotate Genres with @cds.search: {name};
annotate Genres with @readonly;
annotate Genres with {
name @title: '{i18n>Genre}';
}
Expand Down
2 changes: 1 addition & 1 deletion app/genres/webapp/i18n/i18n.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#XTIT
appTitle=Browse Genres
appTitle=Manage Genres
#XTXT
appDescription=Genres as Tree View
2 changes: 1 addition & 1 deletion app/genres/webapp/i18n/i18n_de.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
appTitle=Zeige Genres
appTitle=Verwalte Genres
appDescription=Genres als Baumansicht