feat: tree table modifications #18
Open
+17
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| annotate AdminService.Genres with @odata.draft.enabled; | ||
| // needed for changing a parent | ||
| annotate AdminService.Genres with @odata.draft.bypass; |
Contributor
There was a problem hiding this comment.
Does that mean the maintenance of trees only works with bypass enabled?
Author
There was a problem hiding this comment.
no, you can CREATE, EDIT and DELETE nodes (root and child) without @odata.draft.bypass annotation, only CUT/PASTE (changing a parent with @odata.bind) doesn't work without @odata.draft.bypass, because we are modifying an active entity directly.
Contributor
There was a problem hiding this comment.
I propose we wait until the next release and then use cds.fiori.direct_crud to enable it globally.
Author
There was a problem hiding this comment.
cannot be merged yet because of https://github.tools.sap/cap/cdsnode/issues/2503#issuecomment-18095257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree Table entity
Genresis now enabled for modifications.Following functionality is tested on HANA and SQLite:
Drag&DroporCut/Paste