Skip to content

Add incident links to scheduled maintenance entries #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Misrilal-Sah wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

Add incident links to scheduled maintenance entries #4605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/views/partials/schedule.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div class="list-group">
@foreach($scheduled_maintenance as $schedule)
<div class="list-group-item">
<strong>{{ $schedule->name }}</strong> <small class="date"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></small>
<strong>{{ $schedule->name }}</strong> <small class="date"><a href="{{ route('incident', ['id' => $schedule->id]) }}" class="links"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></a></small>
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The incident route is defined as incident/{incident} (StatusPageRoutes), so passing ['id' => $schedule->id] will not bind the required {incident} parameter (it may generate a query string or throw a missing-parameter error depending on framework behavior). Use a positional parameter (route('incident', $schedule->id)), the correct key (['incident' => $schedule->id]), or $schedule->permalink (IncidentPresenter already provides this).

Suggested change
<strong>{{ $schedule->name }}</strong> <small class="date"><a href="{{ route('incident', ['id' => $schedule->id]) }}" class="links"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></a></small>
<strong>{{ $schedule->name }}</strong> <small class="date"><a href="{{ route('incident', ['incident' => $schedule->id]) }}" class="links"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></a></small>

Copilot uses AI. Check for mistakes.
{!! $schedule->formattedMessage !!}
</div>
@endforeach
Expand Down
Loading