Skip to content

Add incident links to scheduled maintenance entries#4605

Open
Misrilal-Sah wants to merge 1 commit intocachethq:developfrom
Misrilal-Sah:pr/4573-link-planned-maintenance
Open

Add incident links to scheduled maintenance entries#4605
Misrilal-Sah wants to merge 1 commit intocachethq:developfrom
Misrilal-Sah:pr/4573-link-planned-maintenance

Conversation

@Misrilal-Sah
Copy link
Copy Markdown

Issue link id: #4573

Description:
Planned maintenance entries now link to their incident detail page directly from the scheduled section.
This brings behavior in line with historical incidents and avoids forcing users to guess incident IDs for future maintenance events.

Copilot AI review requested due to automatic review settings March 31, 2026 18:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds direct links from Scheduled Maintenance entries to their incident detail pages (/incident/{id}), aligning scheduled items with historical incidents and improving discoverability.

Changes:

  • Wrap the scheduled maintenance “timeago” timestamp with an <a> linking to the incident detail route.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@foreach($scheduled_maintenance as $schedule)
<div class="list-group-item">
<strong>{{ $schedule->name }}</strong> <small class="date"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></small>
<strong>{{ $schedule->name }}</strong> <small class="date"><a href="{{ route('incident', ['id' => $schedule->id]) }}" class="links"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></a></small>
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The incident route is defined as incident/{incident} (StatusPageRoutes), so passing ['id' => $schedule->id] will not bind the required {incident} parameter (it may generate a query string or throw a missing-parameter error depending on framework behavior). Use a positional parameter (route('incident', $schedule->id)), the correct key (['incident' => $schedule->id]), or $schedule->permalink (IncidentPresenter already provides this).

Suggested change
<strong>{{ $schedule->name }}</strong> <small class="date"><a href="{{ route('incident', ['id' => $schedule->id]) }}" class="links"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></a></small>
<strong>{{ $schedule->name }}</strong> <small class="date"><a href="{{ route('incident', ['incident' => $schedule->id]) }}" class="links"><abbr class="timeago" data-toggle="tooltip" data-placement="right" title="{{ $schedule->scheduled_at_formatted }}" data-timeago="{{ $schedule->scheduled_at_iso }}"></abbr></a></small>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants