Skip to content

862 freshdesk tested#5149

Open
nikolinaspehar wants to merge 7 commits into
masterfrom
862-freshdesk
Open

862 freshdesk tested#5149
nikolinaspehar wants to merge 7 commits into
masterfrom
862-freshdesk

Conversation

@nikolinaspehar
Copy link
Copy Markdown
Collaborator

close #862

@nikolinaspehar nikolinaspehar added this to the v0.29 milestone Jun 5, 2026
Copy link
Copy Markdown

@gecko-security gecko-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gecko PR Review

No vulnerabilities found, LGTM.

Summary

This PR updates the Freshdesk component to align its OpenAPI schema and generated definitions with Freshdesk's actual API surface, expanding Company and Contact response objects with 8+ missing fields (domains, health_score, account_tier, created_at, updated_at, etc.) and correcting field types from NUMBER to INTEGER. The changes affect server/libs/modules/components/freshdesk/openapi.yaml and downstream code generation in action handlers and utility classes, requiring validation that serialization/deserialization roundtrips correctly and that new optional fields don't break existing workflow definitions.

Important Files Changed

5 important files out of 12 changed

File Path Why it matters
server/libs/modules/components/freshdesk/openapi.yaml OpenAPI schema is the source of truth for component definition generation; expanded Company and Contact object schemas directly impact action handlers and client-side field mapping.
server/libs/modules/components/freshdesk/src/main/java/com/bytechef/component/freshdesk/util/FreshdeskUtils.java Utility class that maps and serializes API responses; must handle new optional fields without breaking deserialization of existing payloads.
server/libs/modules/components/freshdesk/src/main/java/com/bytechef/component/freshdesk/action/FreshdeskCreateCompanyAction.java Action handler generates output schemas from the OpenAPI definition; new fields must be properly exposed in workflow outputs without altering action input contract.
server/libs/modules/components/freshdesk/src/main/java/com/bytechef/component/freshdesk/action/FreshdeskCreateContactAction.java Contact creation action must correctly map expanded response schema; incorrect field types (NUMBER vs INTEGER) could cause downstream type coercion failures.
server/libs/modules/components/freshdesk/src/test/resources/definition/freshdesk_v1.json Test fixture capturing the generated component definition; must be regenerated and verified to ensure action payloads match the updated schema.

Omitted 7 lower-signal changed files.

Sequence Diagram

sequenceDiagram
    participant WF as Workflow
    participant Handler as FreshdeskCreateCompanyAction
    participant Utils as FreshdeskUtils
    participant API as Freshdesk API
    participant Schema as OpenAPI Schema
    WF->>Handler: Execute action
    Handler->>API: POST /companies
    API-->>Handler: {id:1, name:"...", domains:[...], created_at:"..."}
    Handler->>Utils: Map response
    Utils->>Schema: Validate fields against expanded schema
    Utils-->>Handler: Deserialized object
    Handler-->>WF: Output with new fields available
Loading

Edit Gecko PR Settings | Reviewed commit: b9beae5

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[component] Freshdesk

1 participant