Reuse heap allocations in prepare_mesh_bind_groups#24643
Merged
alice-i-cecile merged 4 commits intoJun 17, 2026
Merged
Conversation
Them are not accessed in render()
alice-i-cecile
approved these changes
Jun 17, 2026
alice-i-cecile
added
A-Rendering
alice-i-cecile
added
the
S-Needs-Review
kfc35
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Reuse
MeshBindGroupsheap allocations inprepare_mesh_bind_groupsSolution
Reuse heap memory from previously existing
MeshBindGroupsresource.Also the lightmaps bind groups should be keyed by metadata slab id otherwise it should be a bug if using vertex compression + lightmap + webgl2
Testing
Examples still work