Skip to content

Update variadics_please requirement from 1.1 to 2.0#24640

Queued
kfc35 wants to merge 2 commits into
bevyengine:mainfrom
kfc35:variadics_please_2.0
Queued

Update variadics_please requirement from 1.1 to 2.0#24640
kfc35 wants to merge 2 commits into
bevyengine:mainfrom
kfc35:variadics_please_2.0

Conversation

@kfc35

@kfc35 kfc35 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Objective

Solution

  • Upgrading caused some large_enum_variant warnings. I box’ed the affected variants.
  • From the original Dependabot PR:

Updates the requirements on variadics_please to permit the latest version.

Changelog

Sourced from variadics_please's changelog.

Version 2.0.0

  • Switch from syn to unsynn
    • syn is known to be a major compile time bottleneck. To improve the situation for users of variadics_please, we switched to unsynn, which is the alternative used by facet.
    • The compile time speedup depends on your local setup and the complexity of the macro invocation, but on one test setup, the cold compilation time went from about 2.16 seconds to 0.56 seconds.
    • The code generated by variadics_please should be identical to before. Our Error messages may look a bit different now, but they should be just as readable. If you encounter any weird behavior or diagnostics, let us know.
  • Use Rust 2024, which bumps the MSRV to 1.85.0

Version 1.1

  • added all_tuples_enumerated, which provides the index of each item in the tuple

Version 1.0.0

  • initial release
    • code was taken directly from bevy_utils 0.15-rc2, under a MIT + Apache dual license
Commits

I’m assuming the changelog doesn’t look concerning

Testing

  • ci

dependabot Bot and others added 2 commits May 15, 2026 06:55
Updates the requirements on [variadics_please](https://github.com/bevyengine/variadics_please) to permit the latest version.
- [Changelog](https://github.com/bevyengine/variadics_please/blob/main/RELEASES.md)
- [Commits](https://github.com/bevyengine/variadics_please/commits)

---
updated-dependencies:
- dependency-name: variadics_please
  dependency-version: 2.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@kfc35 kfc35 added C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 16, 2026
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 17, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Dependencies A change to the crates that Bevy depends on D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants