Entitymut doc changes for #24596#24631
Merged
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
SpecificProtagonist
left a comment
Contributor
There was a problem hiding this comment.
The docs of QueryAccessError should also be updated.
(I've also noticed that the has_conflicts mentioned therein has unclear docs and get_componetns_mut_unchecked technically violates the safety preconditions of WorldQuery::init_fetch, but that's a separate issue).
SpecificProtagonist
approved these changes
Jun 15, 2026
mnmaita
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
EntityWorldMut::get_components_mut_uncheckedare incorrect #24596Solution
Testing