Use send wrapped BindGroupEntry Vec in prepare_mesh_view_bind_groups#24623
Open
beicause wants to merge 2 commits into
Open
Use send wrapped BindGroupEntry Vec in prepare_mesh_view_bind_groups#24623beicause wants to merge 2 commits into
prepare_mesh_view_bind_groups#24623beicause wants to merge 2 commits into
Conversation
kfc35
added
A-Rendering
kfc35
added
C-Performance
kfc35
approved these changes
Jun 16, 2026
kfc35
left a comment
kfc35
left a comment
Contributor
There was a problem hiding this comment.
looks good to me
i tested building the 3d_scene for wasm with the atomics target-feature and ran it locally. I did not run into problems
RUSTFLAGS='-C target-feature=+atomics,+bulk-memory --cfg getrandom_backend="wasm_js"' cargo build --release --example 3d_scene --target wasm32-unknown-unknown
wasm-bindgen --out-name wasm_example \
--out-dir examples/wasm/target \
--target web target/wasm32-unknown-unknown/release/examples/3d_scene.wasm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Address the TODO in
prepare_mesh_view_bind_groupsSolution
Use
WgpuWrapper<Vec<BindGroupEntry<'static>>>instead of feature gate.We already use WgpuWrapper for wgpu objects to make them Send on wasm with atomics so that the target compiles.
Testing
CI