Hybrid Resources#24597
Draft
Trashtalk217 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This is a response to #24591 and #24592.
In short, during the resources-as-components proces it was decided that
trait Resource : Componentinstead of using a wrapper component likeResourceData<R: Resource>(R). This caused one major regression:Double derives were no longer possible. This is occasionally useful. One particular example would be global settings with local overrides. You would set a global default which you could locally override for a specific entity - all within the same type. Because this was now disallowed, you had to split your struct into two:
This is verbose and generally not ideal.
Solution
Introduce
HybridResource: Types that implement this trait function both as aResourceand aComponent, roughly mimicking the old#[derive(Resource, Component)]behaviour.Problems
world.spawn()andworld.insert_resource()so if you doworld.spawn()before doingworld.insert_resource()it will assume that theworld.spawn()ed value is the resource, not the component. A real solution might just have to bring back the wrapper type.