Skip to content

Fix glTF specular extension parsing#24580

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
issam3105:Fix_glTF_specular_extension_parsing
Jun 11, 2026
Merged

Fix glTF specular extension parsing#24580
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
issam3105:Fix_glTF_specular_extension_parsing

Conversation

@issam3105

@issam3105 issam3105 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Objective

  • Fix a regression introduced by Enable glTF validation for KHR_materials_specular #24571 where KHR_materials_specular was added to the enabled gltf crate features. This was missed because the asset i used for testing did not make the specular parsing regression visually obvious.
  • After enabling this feature, the gltf crate parses KHR_materials_specular as a known typed extension, so it is no longer returned by material.extensions(), which only exposes unknown extension data.

Solution

Read KHR_materials_specular through the typed material.specular() API exposed by the gltf crate.

Testing

Reviewers can test visually by loading the Khronos SpecularTest

@issam3105 issam3105 force-pushed the Fix_glTF_specular_extension_parsing branch from c60349b to 2da9d02 Compare June 10, 2026 10:09
@issam3105 issam3105 force-pushed the Fix_glTF_specular_extension_parsing branch from 2da9d02 to f73a613 Compare June 10, 2026 10:20
@kfc35 kfc35 added C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-glTF Related to the glTF 3D scene/model format D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jun 10, 2026

@kfc35 kfc35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 11, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 11, 2026
Merged via the queue into bevyengine:main with commit cfa6c44 Jun 11, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-glTF Related to the glTF 3D scene/model format C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants