Skip to content

fix non move multi boosts #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikiris wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix non move multi boosts #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/overlords/Overlord.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ export abstract class Overlord {
const [moveBoosts, nonMoveBoosts] = _.partition(neededBoostResources,
resource => Abathur.isMoveBoost(<ResourceConstant>resource));

for (const boost of [...moveBoosts, nonMoveBoosts]) { // try to get move boosts first if they're available
for (const boost of [...moveBoosts, ...nonMoveBoosts]) { // try to get move boosts first if they're available
Copy link
Copy Markdown
Contributor

@ahmedcharles ahmedcharles May 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change this to have typescript help a little:

      const neededBoosts = zerg.getNeededBoosts();
      const neededBoostResources = _.keys(neededBoosts) as MineralBoostConstant[];

      const [moveBoosts, nonMoveBoosts] = _.partition(neededBoostResources,
                              resource => Abathur.isMoveBoost(<ResourceConstant>resource));

      for (const boost of [...moveBoosts, ...nonMoveBoosts]) { // try to get move boosts first if they're available
        const b: MineralBoostConstant = boost; // Have the types help ensure correctness.
        const boostLab = _.find(evolutionChamber.boostingLabs, lab => lab.mineralType === b);
        if (boostLab) {
          zerg.task = Tasks.getBoosted(boostLab, <ResourceConstant>boost);
          return;
        }
      }

Other than that, LGTM.

const boostLab = _.find(evolutionChamber.boostingLabs, lab => lab.mineralType == boost);
if (boostLab) {
zerg.task = Tasks.getBoosted(boostLab, <ResourceConstant>boost);
Expand Down