Open
Conversation
| resource => Abathur.isMoveBoost(<ResourceConstant>resource)); | ||
|
|
||
| for (const boost of [...moveBoosts, nonMoveBoosts]) { // try to get move boosts first if they're available | ||
| for (const boost of [...moveBoosts, ...nonMoveBoosts]) { // try to get move boosts first if they're available |
Contributor
There was a problem hiding this comment.
I'd change this to have typescript help a little:
const neededBoosts = zerg.getNeededBoosts();
const neededBoostResources = _.keys(neededBoosts) as MineralBoostConstant[];
const [moveBoosts, nonMoveBoosts] = _.partition(neededBoostResources,
resource => Abathur.isMoveBoost(<ResourceConstant>resource));
for (const boost of [...moveBoosts, ...nonMoveBoosts]) { // try to get move boosts first if they're available
const b: MineralBoostConstant = boost; // Have the types help ensure correctness.
const boostLab = _.find(evolutionChamber.boostingLabs, lab => lab.mineralType === b);
if (boostLab) {
zerg.task = Tasks.getBoosted(boostLab, <ResourceConstant>boost);
return;
}
}Other than that, LGTM.
zGeneral
pushed a commit
to zGeneral/Overmind
that referenced
this pull request
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
Fixes boosting on dev branch when doing multiple boosts.
Fixed:
Non move boosts when doing multiple boosts.
Testing checklist:
tsconfigconfiguration