Skip to content

update graph tooltip when not moving #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phyrophone wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update graph tooltip when not moving #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae39853
always update graph tooltip
phyrophone May 8, 2026
3852f87
remove conflicting graph tooltip
phyrophone May 8, 2026
2f42439
Merge branch 'master' into graph-tooltip-v4
phyrophone May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/perf/gpudetailwidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ GpuDetailWidget::GpuDetailWidget(QWidget *parent) : QWidget(parent), ui(new Ui::
configureGraph(this->ui->copyBwGraphWidget);
this->ui->copyBwGraphWidget->SetSeriesNames(tr("TX"), tr("RX"));
this->ui->copyBwGraphWidget->SetValueFormat(GraphWidget::ValueFormat::BytesPerSec);
this->ui->copyBwGraphWidget->setToolTip(tr("Copy bandwidth: light trace = TX, dark trace = RX"));
Copy link
Copy Markdown
Owner

@benapetr benapetr May 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed, was it redundant in the UI? I don't have a test machine with GPU with me right now to see the change

Copy link
Copy Markdown
Contributor Author

@phyrophone phyrophone May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

video of the bug:

2026-05-16.21-26-06.mp4

Message from the commit:

remove conflicting graph tooltip
the tooltip is being set both by this line and by graphwidget.cpp, causing the tooltip's text to flicker back and forth.

originally I thought that my changes triggered the bug. Though testing it now, the bug seems to also be present on master

UIHelper::EnableGraphContextMenu(this->ui->copyBwGraphWidget);

UIHelper::EnableCopyLabelContextMenu(this->ui->utilValueLabel);
Expand Down
68 changes: 39 additions & 29 deletions src/perf/graphwidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,9 @@ void GraphWidget::paintEvent(QPaintEvent * /*event*/)
p.setPen(QPen(hover, 1));
p.drawLine(QPointF(x, contentTop), QPointF(x, contentBottom));
}

if (this->m_isHovered)
updateTooltip();
}

void GraphWidget::mouseMoveEvent(QMouseEvent *event)
Expand All @@ -296,41 +299,14 @@ void GraphWidget::mouseMoveEvent(QMouseEvent *event)
this->update(oldRect.united(this->hoverLineRect(this->m_hoverSlot)));
}

if (this->m_hoverTooltipEnabled && slotChanged)
{
const int idx1 = sampleIndexForSlot(this->m_data ? this->m_data->Size() : 0, slot, sampleCount);
const int idx2 = sampleIndexForSlot(this->m_overlayData ? this->m_overlayData->Size() : 0, slot, sampleCount);

if (idx1 >= 0 || idx2 >= 0)
{
QString tip;
if (idx1 >= 0)
tip += tr("%1: %2").arg(this->m_primaryName, this->formatValue(this->m_data->At(idx1)));
if (idx2 >= 0)
{
if (!tip.isEmpty())
tip += "\n";
tip += tr("%1: %2").arg(this->m_secondaryName, this->formatValue(this->m_overlayData->At(idx2)));
}
const int secAgo = sampleCount - 1 - slot;
if (!tip.isEmpty())
tip += tr("\n%1 s ago").arg(secAgo);
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
QToolTip::showText(event->globalPosition().toPoint(), tip, this);
#else
QToolTip::showText(event->globalPos(), tip, this);
#endif
} else
{
QToolTip::hideText();
}
}
this->m_isHovered = true;

QWidget::mouseMoveEvent(event);
}

void GraphWidget::leaveEvent(QEvent *event)
{
this->m_isHovered = false;
const QRect oldRect = this->hoverLineRect(this->m_hoverSlot);
this->m_hoverSlot = -1;
if (this->m_hoverTooltipEnabled)
Expand Down Expand Up @@ -394,3 +370,37 @@ QString GraphWidget::formatValue(double v) const
return QString::number(v, 'f', 2);
}
}

void GraphWidget::updateTooltip()
{
if (this->m_hoverTooltipEnabled)
{
const int sampleCount = qMax(2, this->m_sampleCapacity);
const double stepX = static_cast<double>(qMax(1, this->width())) / static_cast<double>(sampleCount - 1);
const double mouseX = mapFromGlobal(QCursor::pos()).x();
const int slot = qBound(0, static_cast<int>(std::lround(mouseX / stepX)), sampleCount - 1);

const int idx1 = sampleIndexForSlot(this->m_data ? this->m_data->Size() : 0, slot, sampleCount);
const int idx2 = sampleIndexForSlot(this->m_overlayData ? this->m_overlayData->Size() : 0, slot, sampleCount);

if (idx1 >= 0 || idx2 >= 0)
{
QString tip;
if (idx1 >= 0)
tip += tr("%1: %2").arg(this->m_primaryName, this->formatValue(this->m_data->At(idx1)));
if (idx2 >= 0)
{
if (!tip.isEmpty())
tip += "\n";
tip += tr("%1: %2").arg(this->m_secondaryName, this->formatValue(this->m_overlayData->At(idx2)));
}
const int secAgo = sampleCount - 1 - slot;
if (!tip.isEmpty())
tip += tr("\n%1 s ago").arg(secAgo);
QToolTip::showText(QCursor::pos(), tip, this);
} else
{
QToolTip::hideText();
}
}
}
2 changes: 2 additions & 0 deletions src/perf/graphwidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ namespace Perf
bool m_gridEnabled { true };
int m_sampleCapacity { 60 }; ///< Matches the default history window in seconds.
int m_historyTick { 0 }; ///< Advances as samples arrive; used for grid phase.
bool m_isHovered { false };
int m_hoverSlot { -1 };
bool m_hoverLineEnabled { true };
bool m_hoverTooltipEnabled { true };
Expand All @@ -131,6 +132,7 @@ namespace Perf
QRect hoverLineRect(int slot) const;
static int sampleIndexForSlot(int size, int slot, int sampleCount);
QString formatValue(double v) const;
void updateTooltip();
};
} // namespace Perf

Expand Down
Loading