update graph tooltip when not moving#55
Conversation
update the text of the tooltip even when not moving the tooltip
the tooltip is being set both by this line and by graphwidget.cpp, causing the tooltip's text to flicker back and forth.
| configureGraph(this->ui->copyBwGraphWidget); | ||
| this->ui->copyBwGraphWidget->SetSeriesNames(tr("TX"), tr("RX")); | ||
| this->ui->copyBwGraphWidget->SetValueFormat(GraphWidget::ValueFormat::BytesPerSec); | ||
| this->ui->copyBwGraphWidget->setToolTip(tr("Copy bandwidth: light trace = TX, dark trace = RX")); |
There was a problem hiding this comment.
Why was this removed, was it redundant in the UI? I don't have a test machine with GPU with me right now to see the change
There was a problem hiding this comment.
video of the bug:
2026-05-16.21-26-06.mp4
Message from the commit:
remove conflicting graph tooltip
the tooltip is being set both by this line and by graphwidget.cpp, causing the tooltip's text to flicker back and forth.
originally I thought that my changes triggered the bug. Though testing it now, the bug seems to also be present on master
|
yes I am aware of that bug, but I am not sure if this is fixing it - or is it? can you confirm this is fixing it? I though the solution for this flicker would be to add some kind of timer / delay that prevents updating the tooltip more often than N seconds, but maybe what you did fixes it as well? It seems to me that whatever you are fixing in this PR is trying to fix something else though - just judging from the code changes this makes the tooltip update automatically when mouse isn't moving (is on constant spot) and the underlying graph is moving. Which is... interesting and probably more wanted than unwanted, although I can imagine scenarios where it could actually be unwanted as well - imagine you have some peak in the graph, you want to check the number, you move the mouse on it, tooltip appears - now you have time to read it. With this patch tooltip will be changing each tick (unless you manage to mouse the move fast enough to keep it hovered on that peak you want to observe). |
2 participants
Previously, the graph tooltip only got updated when it was moved left/right. This pr fixes that.