Open
Conversation
Owner
|
Are you sure this commit is complete? It looks like if there's missing something. Also shellcheck (https://www.shellcheck.net/) throws a syntax error. |
- rework statemant to be more clear
- append check of json-rpc mode to rootless part
bbernhard
requested changes
Mar 6, 2024
Owner
bbernhard
left a comment
bbernhard
left a comment
There was a problem hiding this comment.
Personally I would prefer to wrap the relevant code parts (usermod, groupmod, etc) in the if block, instead of duplicating the code. Duplicating the code makes it harder to maintain and code can easily be lost (e.g in you code part the WARNING message isn't set in the .bashrc file and the HOST_IP is also not set)
|
Is there a chance that we get this fixed and merged? |
kaktus42
added a commit
to kaktus42/signal-cli-rest-api
that referenced
this pull request
Feb 15, 2026
fixing bbernhard#491 according to review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #490