Conversation
fixing bbernhard#491 according to review comments
|
Thanks for the PR! I quickly looked over the code and at first glance it looks really good. I'll have a more in-depth look at it in the next days, when I have a bit more time. |
|
Hi created an image based on @kaktus42 patch-1 branch.
This is good no breaking changes!
fixed next issue: fixed next issue Fixed this with an init container copying the file into an emptydir and remoted it with proper permissions. next issue: another emptydir to I really appreciate the efforts to create an non-root container. I know running in K8s is slightly different than docker, but I hope my test above will help. Happy to do more tests. |
|
Thanks for running the tests! As this goes a bit deeper as I thought, I'm not sure if I can find the time to make the necessary changes. |
|
@bbernhard I may want to spent some cycles on this, but want to discuss some directions first.
|
|
@poggenpower Thanks for your tests - that's very much appreciated! I am currently also having a look at running the image rootless, but unfortunately I am still fighting a bit with
I'd say it's more for historic reasons - at least I can't think of any reason right now that would require root. I am definitely open to improvements in that regard. My checklist/"wishlist" would be:
|
|
Ok I will give it a try, it may need a while. Maybe
So the new images will move to non-root as default and start as before user should only recognize if they do fancy things. Are those changes acceptable from you prospective? Maybe it is also an option to play out a non-root image in parallel for a while to collect some community feedback. I can't really push to this PR, how should we proceed with it. Should we close this and I create a new one if I have a version. Should we move the discussion into an issue. Whats your preferred way there? |
fixing pr #491 (issue #490) according to review comments