Improve usability of tags #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sem-ver: api-break Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Adds a way to filter the list in `referenced_by_flows` on `GET /objects/<objectId>` based on the tags on that Flow. Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
11 tasks
j616
approved these changes
Oct 8, 2025
Contributor
j616
left a comment
j616
left a comment
There was a problem hiding this comment.
LGTM. A couple of updates suggested for consistency.
Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
samdbmg
force-pushed
the
sammg-tags-listing-changes
branch
from
e5cb4d3 to
2dc8b59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Extracts the changes to how tags behave from #115 into a separate PR, and adds a matching ADR, since those changes are generally useful and not coupled in to authorisation.
I'd appreciate a review pass on this before I bump the ADR to "accepted" (which CI will enforce that I do)
Jira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-3534
Related PRs
Extracts parts of #115 (which will need conflict resolution/refactoring)
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.