Skip to content

Conversation

@samdbmg
Copy link
Member

@samdbmg samdbmg commented Oct 1, 2025

Details

  • Adds AppNote 0016 proposing approaches to handling authorisation in TAMS
  • Adds corresponding ADR
  • Makes some object instance behaviours clearer when objects have not been registered as segments
  • Slightly re-orders the README

Note: This PR is based on #115 however has been simplified by separating the tags change out (now #153) and removing the precise details of how a tag-based authz proxy could be implemented. Instead an implementation will be added to the examples/ directory in a future PR.
In addition the history and multiple rounds of iteration of that PR has been collapsed.

Jira Issue (if relevant)

Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-3534

Related PRs

Supersedes #115

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

Base automatically changed from sammg-tags-listing-changes to main October 10, 2025 15:12
@samdbmg samdbmg force-pushed the sammg-simpler-authz-appnote branch from 301f516 to cbe7323 Compare October 10, 2025 15:24
@samdbmg samdbmg marked this pull request as ready for review October 10, 2025 15:24
@samdbmg samdbmg requested a review from a team as a code owner October 10, 2025 15:24
samdbmg and others added 6 commits November 18, 2025 15:34
Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Adds an application note describing authorisation in TAMS.
Note that this is the state of the appnote at 01f2140 in
#115 - at that point it was reworked
into multiple PRs and the history flattened.

Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Clarifies that object ID/URL pairs that were never registered as Flow
Segments should not be returned in the listing.

Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Co-Authored-By: James Sandford <james.sandford@bbc.co.uk>
Restructures to move the details of the `auth_classes` tag based
implementation out of the main application note, and instead talk in
more general terms about how to implement it.
Improves various wording based on review comments
@samdbmg samdbmg force-pushed the sammg-simpler-authz-appnote branch from cbe7323 to 5f40e73 Compare November 18, 2025 15:35
Copy link
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
@samdbmg samdbmg requested a review from j616 November 19, 2025 11:09
@samdbmg samdbmg merged commit 6bea55f into main Nov 19, 2025
8 checks passed
@samdbmg samdbmg deleted the sammg-simpler-authz-appnote branch November 19, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants