-
Notifications
You must be signed in to change notification settings - Fork 7
Add AppNote covering authorisation (simplified version of #115) #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j616
reviewed
Oct 8, 2025
301f516 to
cbe7323
Compare
danjhd
reviewed
Nov 6, 2025
Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Clarifies that object ID/URL pairs that were never registered as Flow Segments should not be returned in the listing. Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
Co-Authored-By: James Sandford <james.sandford@bbc.co.uk>
Restructures to move the details of the `auth_classes` tag based implementation out of the main application note, and instead talk in more general terms about how to implement it.
Improves various wording based on review comments
cbe7323 to
5f40e73
Compare
j616
approved these changes
Nov 19, 2025
Contributor
j616
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
j616
requested changes
Nov 19, 2025
Co-authored-by: James Sandford <james.sandford@bbc.co.uk>
j616
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Note: This PR is based on #115 however has been simplified by separating the tags change out (now #153) and removing the precise details of how a tag-based authz proxy could be implemented. Instead an implementation will be added to the
examples/directory in a future PR.In addition the history and multiple rounds of iteration of that PR has been collapsed.
Jira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-3534
Related PRs
Supersedes #115
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.