Skip to content

Conversation

@j616
Copy link
Contributor

@j616 j616 commented Jul 31, 2025

Details

Adds Object Instance management endpoints to support the creation/management of duplicate instances of Objects across multiple storage backends.

Jira Issue (if relevant)

Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5448

Related PRs

If merged before #115, add the new endpoints to the auth logic listings in that PR. If merged after, add that logic in this PR

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner July 31, 2025 09:27
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - a few thoughts on the server/client piece inlined.

Sorry about all the nits!

j616 and others added 12 commits September 23, 2025 11:07
…he objects endpoint. Update references to flow segments that should be to media objects.
…ring additional object URLs, and deleting object URLs
…nts to avoid race conditions with Object garbage collection.
Co-authored-by: Sam Mesterton-Gibbons <sam.mesterton-gibbons@bbc.co.uk>
Co-authored-by: Georgina Shippey <9370167+GeorginaShippey@users.noreply.github.com>
Co-authored-by: Georgina Shippey <9370167+GeorginaShippey@users.noreply.github.com>
@j616 j616 force-pushed the jamessa-objects branch 2 times, most recently from e9bd50c to d055c51 Compare September 23, 2025 10:44
@j616 j616 requested a review from samdbmg September 23, 2025 10:50
@samdbmg samdbmg self-assigned this Sep 24, 2025
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rework LGTM

@samdbmg samdbmg removed their assignment Sep 24, 2025
@j616 j616 merged commit 4b68674 into main Sep 24, 2025
8 checks passed
@j616 j616 deleted the jamessa-objects branch September 24, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants