Skip to content

Conversation

@j616
Copy link
Contributor

@j616 j616 commented Oct 13, 2025

Details

Makes label mandatory when registering uncontrolled Object Instances. This prevents the creation of Object Instances that have no defined mechanisms for modification/deletion.

Jira Issue (if relevant)

Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5492

Related PRs

This PR was created following feedback on #144

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner October 13, 2025 14:13
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - couple of docs ideas and nits inlined

j616 and others added 4 commits October 20, 2025 15:47
@j616 j616 force-pushed the jamessa-uncontrolledLabels branch from 8210494 to 8a8eae6 Compare October 20, 2025 14:47
@j616 j616 force-pushed the jamessa-uncontrolledLabels branch from 635f4e7 to 5659e5a Compare October 20, 2025 14:50
@j616 j616 merged commit a7d7088 into main Oct 20, 2025
8 checks passed
@j616 j616 deleted the jamessa-uncontrolledLabels branch October 20, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants