Skip to content

Fix spurious debug logging in api.py #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Derb237 wants to merge 1 commit into from
Closed

Fix spurious debug logging in api.py #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/synack/plugins/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def request(self, method, path, attempts=0, **kwargs):
elif res.status_code == 403:
reason_failed = 'Logged out'
elif res.status_code == 412:
fail_reason = 'Mission already claimed'
reason_failed = 'Mission already claimed'
elif res.status_code == 429:
self._debug.log('Too many requests', f'({res.status_code} - {res.reason}) {res.url}')
if attempts < 5:
Expand All @@ -165,6 +165,8 @@ def request(self, method, path, attempts=0, **kwargs):
attempts += 1
return self.request(method, path, attempts, **kwargs)

self._debug.log('Mission already claimed', f'({res.status_code} - {res.reason}) {res.url}')
# Log terminal failures (non-retryable errors)
if res.status_code in [400, 401, 403, 412]:
self._debug.log(reason_failed, f'({res.status_code} - {res.reason}) {res.url}')

return res