Fix spurious debug logging in api.py #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed two bugs in the request error handling: 1. Line 153: Fixed typo where 'fail_reason' was set instead of 'reason_failed' for HTTP 412 status codes 2. Line 168: Moved unconditional debug log into a conditional that only logs terminal failures (400, 401, 403, 412) Previously, when debug mode was enabled, every HTTP request would log 'MISSION ALREADY CLAIMED' regardless of the actual status code or context. This was caused by an unconditional debug.log() call that always executed. Now, 'Mission already claimed' only appears for actual HTTP 412 errors. Bug introduced in commit c406ca9 (March 2, 2025)
Derb237
force-pushed
the
fix/debug-logging-spurious-messages
branch
from
85fb6ab to
53a5be7
Compare
Author
|
Superseded by enhanced fix in PR #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two bugs in the request error handling that caused misleading debug messages when debug mode was enabled.
Issues Fixed
1. Typo in variable name (Line 153)
fail_reason = 'Mission already claimed'reason_failed = 'Mission already claimed'fail_reasonwas never used, causing the message to never be logged correctly2. Unconditional debug log (Line 168)
Impact
When
debug=Truewas set, users would see confusing "MISSION ALREADY CLAIMED" messages for every single HTTP request, even ones completely unrelated to missions.Example - Before fix:
After fix:
Now "Mission already claimed" only appears for actual HTTP 412 responses.
Root Cause
Bug was introduced in commit c406ca9 (March 2, 2025) during refactoring of error handling code.
Testing
Tested with
debug=Trueusingsynack_check_target.py- confirmed spurious messages are gone and only appropriate errors are logged.