Skip to content

feat: expose ability to publish otel metrics to remote endpoint #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hweinstock wants to merge 1 commit into from
Closed

feat: expose ability to publish otel metrics to remote endpoint #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/cli/telemetry/client-accessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { OtelMetricSink } from './sinks/otel-metric-sink.js';
import { join } from 'path';

/**
Expand Down Expand Up @@ -35,6 +36,7 @@ async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Pr

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;
const endpoint = process.env.AGENTCORE_TELEMETRY_ENDPOINT ?? config.telemetry?.endpoint;

if (audit) {
const filePath = resolveAuditFilePath(
Expand All @@ -45,5 +47,9 @@ async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Pr
sinks.push(new FileSystemSink({ filePath, resource }));
}

if (endpoint) {
sinks.push(new OtelMetricSink({ endpoint, resource }));
Comment thread
Hweinstock marked this conversation as resolved.
}

return new TelemetryClient(new CompositeSink(sinks));
}
1 change: 1 addition & 0 deletions src/cli/telemetry/sinks/otel-metric-sink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export class OtelMetricSink implements MetricSink {
headers: { 'X-Installation-Id': config.resource['agentcore-cli.installation_id'] },
temporalityPreference: AggregationTemporality.DELTA,
});

Comment thread
Hweinstock marked this conversation as resolved.
this.meterProvider = new MeterProvider({
resource,
readers: [
Expand Down
Loading