Skip to content

feat: expose ability to publish otel metrics to remote endpoint#1243

Closed
Hweinstock wants to merge 1 commit into
aws:mainfrom
Hweinstock:feat/allow-endpoint-injection
Closed

feat: expose ability to publish otel metrics to remote endpoint#1243
Hweinstock wants to merge 1 commit into
aws:mainfrom
Hweinstock:feat/allow-endpoint-injection

Conversation

@Hweinstock

@Hweinstock Hweinstock commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

Wire up the OtelMetricSink to the telemetry client when AGENTCORE_TELEMETRY_ENDPOINT is set (via env var or global config). This enables publishing CLI metrics to a remote OTLP-compatible endpoint. The endpoint can also be configured via telemetry.endpoint in the global config file.

Note: this is not enabling telemetry! The intent is to allow the team to manually add the endpoint to their config to start collecting some real data, users that do not explicitly edit their config with an endpoint will be unaffected.

Testing

verified metrics are making to to collector when injecting the endpoint. They are currently being dropped due to an issue in validation that has its own fix.

Related Issue

Closes #

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/xs PR size: XS label May 14, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.13.1.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-1243-tarball/aws-agentcore-0.13.1.tgz

@agentcore-cli-automation agentcore-cli-automation left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the remote OTLP path. I have one significant concern around opt-out semantics, plus a smaller URL-construction note. See inline comments.

Comment thread src/cli/telemetry/client-accessor.ts
Comment thread src/cli/telemetry/sinks/otel-metric-sink.ts
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 14, 2026
@Hweinstock Hweinstock closed this May 14, 2026
@Hweinstock Hweinstock deleted the feat/allow-endpoint-injection branch May 14, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants