feat: expose ability to publish otel metrics to remote endpoint#1243
Closed
Hweinstock wants to merge 1 commit into
Closed
feat: expose ability to publish otel metrics to remote endpoint#1243Hweinstock wants to merge 1 commit into
Hweinstock wants to merge 1 commit into
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-1243-tarball/aws-agentcore-0.13.1.tgz |
agentcore-cli-automation
suggested changes
May 14, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Thanks for adding the remote OTLP path. I have one significant concern around opt-out semantics, plus a smaller URL-construction note. See inline comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wire up the OtelMetricSink to the telemetry client when
AGENTCORE_TELEMETRY_ENDPOINTis set (via env var or global config). This enables publishing CLI metrics to a remote OTLP-compatible endpoint. The endpoint can also be configured viatelemetry.endpointin the global config file.Note: this is not enabling telemetry! The intent is to allow the team to manually add the endpoint to their config to start collecting some real data, users that do not explicitly edit their config with an endpoint will be unaffected.
Testing
verified metrics are making to to collector when injecting the endpoint. They are currently being dropped due to an issue in validation that has its own fix.
Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.