Skip to content

Keep Bismillah below the reader toolbar after swipe navigation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ariful19 merged 2 commits into from
Apr 26, 2026
Merged

Keep Bismillah below the reader toolbar after swipe navigation #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6008047
Initial plan
Copilot Apr 26, 2026
336284f
fix: keep basmala below fullscreen toolbar on swipe
Copilot Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/src/reader_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ class _SurahReaderPageState extends State<SurahReaderPage> {
child: Stack(
children: [
SafeArea(
top: false,
left: false,
right: false,
bottom: false,
child: Padding(
padding: const EdgeInsets.fromLTRB(8, 8, 8, 20),
Expand Down
47 changes: 47 additions & 0 deletions test/widget_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,53 @@ void main() {
expect(find.text('The Cow'), findsOneWidget);
});

testWidgets(
'reader swipe keeps the basmala below the toolbar without saved progress',
(tester) async {
tester.view.physicalSize = const Size(400, 700);
tester.view.devicePixelRatio = 1.0;
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);

final controller = QuranAppController(
catalogSource: _FakeCatalogSource(),
appStateStore: _MemoryStateStore(),
);
await controller.load();

await tester.pumpWidget(
MaterialApp(
theme: ThemeData(useMaterial3: true),
home: MediaQuery(
data: const MediaQueryData(
padding: EdgeInsets.only(top: 32),
viewPadding: EdgeInsets.only(top: 32),
),
child: SurahReaderPage(
controller: controller,
surahIndex: 1,
),
),
),
);
await tester.pumpAndSettle();

await tester.drag(
find.byKey(const Key('reader-swipe-area')),
const Offset(220, 0),
);
await tester.pumpAndSettle();

final basmalaRect = tester.getRect(
find.byKey(const Key('reader-basmala-header')),
);
final progressButtonRect = tester.getRect(
find.byKey(const Key('reader-progress-button')),
);

expect(basmalaRect.top, greaterThan(progressButtonRect.bottom));
});

testWidgets('reader swipe right to left opens the previous surah',
(tester) async {
tester.view.physicalSize = const Size(400, 700);
Expand Down