Skip to content

Keep Bismillah below the reader toolbar after swipe navigation#7

Merged
ariful19 merged 2 commits into
mainfrom
copilot/fix-bismillah-position-sura-change
Apr 26, 2026
Merged

Keep Bismillah below the reader toolbar after swipe navigation#7
ariful19 merged 2 commits into
mainfrom
copilot/fix-bismillah-position-sura-change

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 26, 2026

When changing surahs by swipe, opening a surah with no remembered reading position could render the Bismillah/header content underneath the fullscreen title bar. This updates the initial reader layout so first-load content starts below the toolbar instead of relying on a fixed top offset.

  • Reader layout

    • Apply the top safe-area inset to the reader canvas while keeping the fullscreen toolbar overlay behavior unchanged.
    • Preserve the existing bottom/side spacing and swipe-based surah navigation flow.
  • Regression coverage

    • Add a widget test that simulates a device with extra top inset, swipes to the next surah with no saved resume position, and asserts that the Bismillah header appears below the toolbar controls.
  • Relevant change

    SafeArea(
      left: false,
      right: false,
      bottom: false,
      child: Padding(
        padding: const EdgeInsets.fromLTRB(8, 8, 8, 20),
        child: _ReaderCanvas(...),
      ),
    )

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/flutter_infra_release/releases/releases_linux.json
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)
  • https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.24.0-stable.tar.xz
    • Triggering command: /usr/bin/curl curl -L --retry 3 --retry-delay 5 REDACTED -o flutter.tar.xz (http block)
  • mirrors.cernet.edu.cn
    • Triggering command: /usr/bin/curl curl -I -L --retry 2 REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix bismillah position during sura change Keep Bismillah below the reader toolbar after swipe navigation Apr 26, 2026
Copilot AI requested a review from ariful19 April 26, 2026 04:57
@ariful19 ariful19 marked this pull request as ready for review April 26, 2026 05:02
@ariful19 ariful19 merged commit f49ac72 into main Apr 26, 2026
3 checks passed
@ariful19 ariful19 deleted the copilot/fix-bismillah-position-sura-change branch April 26, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment